Error Creating Stored Procedure in SQLServer

Question

This is my stored procedure I am trying to create:

CREATE PROCEDURE [cih_owner].[UpdateDisplayOrder]
    @CbpTableName varchar (21), 
    @CbpObjId int,
    @CbpId int,
    @DisplayOrder int
AS
BEGIN
    IF (@CbpTableName = "CbpActivity")
    BEGIN
        UPDATE [cih_owner].[CbpActivity] SET DisplayOrder = @DisplayOrder WHERE Id = @CbpObjId AND CbpId = @CbpId
        ;
    END
END
GO

However, in line that reads: (@CbpTableName = "CbpActivity") I get squigglies under "CbpActivity" with the error Invalid column name 'CbpActivity'

All I am trying to do is compare a string that I sent to the stored procedure.

Thanks!

LittleBobbyTables - Au Revoir · Accepted Answer · 2012-11-06 18:39:10Z

1

You need to use apostrophes instead of quotations for string literals:

IF (@CbpTableName = 'CbpActivity')

answered Nov 6, 2012 at 18:39

LittleBobbyTables - Au Revoir

32.9k25 gold badges113 silver badges115 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

Rednaxel · Accepted Answer · 2012-11-06 18:39:47Z

0

Have you tried to modified the " for ' like this:

CREATE PROCEDURE [cih_owner].[UpdateDisplayOrder]
    @CbpTableName varchar (21), 
    @CbpObjId int,
    @CbpId int,
    @DisplayOrder int
AS
BEGIN
    IF (@CbpTableName = 'CbpActivity')
    BEGIN
        UPDATE [cih_owner].[CbpActivity] SET DisplayOrder = @DisplayOrder WHERE Id = @CbpObjId AND CbpId = @CbpId
        GO
    END
END
GO

answered Nov 6, 2012 at 18:39

Rednaxel

9683 gold badges16 silver badges35 bronze badges

1 Comment

Aaron Bertrand Over a year ago

Do you think the GO really still belongs in the middle of the procedure?

codingbiz · Accepted Answer · 2012-11-06 18:39:49Z

0

You should be using single quote

IF (@CbpTableName = 'CbpActivity')

String are enclosed in single quotes in SQL

answered Nov 6, 2012 at 18:39

codingbiz

26.4k9 gold badges62 silver badges99 bronze badges

Collectives™ on Stack Overflow

Error Creating Stored Procedure in SQLServer

3 Answers 3

Comments

1 Comment

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

3 Answers 3

Comments

1 Comment

Comments

Your Answer

Sign up or log in

Post as a guest

Related