stuck in while loop python

Question

I am creating a chat server in python and got quite far as a noob in the language. I am having 1 problem at the moment which I want to solve before I go further, but I cannot seem to find how to get the problem solved.

It is about a while loop that continues..

in the below code is where it goes wrong

while 1:
    try:
        data = self.channel.recv ( 1024 )
        print "Message from client: ", data
        if "exit" in data:
            self.channel.send("You have closed youre connection.\n")
            break
    except KeyboardInterrupt:
        break
    except:
        raise

When this piece of code get executed, on my client I need to enter "exit" to quit the connection. This works as a charm, but when I use CTRL+C to exit the connection, my server prints "Message from client: " a couple of thousand times.

where am I going wrong?

It sounds like you're closing the client. Recv probably returns false and thus you're stuck in the while loop. — Florin Stingaciu
– Florin Stingaciu, Commented Nov 6, 2012 at 17:02
Think twice about using if 'exit' in data:. If this is a chat server, this means no one can ever send a message containing the word 'exit' unless they manage to make it span across 2 buffer-sized data blocks. if data == 'exit': will probably work more as you'd like. — Silas Ray
– Silas Ray, Commented Nov 6, 2012 at 17:12
@sr2222 I agree. However in the context of my chatserver, it does not seem to work if I replace the if statement with "if data == "exit" ", therefor I replaced the word with "/exit". This works fine now. Thx for the advice. — bryanvan
– bryanvan, Commented Nov 6, 2012 at 17:24

NPE · Accepted Answer · 2012-11-06 17:08:52Z

4

You're pressing Ctrl-C on the client side. This causes the server's self.channel to get closed.

Since calling recv() on a closed channel immediately returns a blank string, your server code gets stuck in an infinite loop.

To fix this, add the following line to your server code:

data = self.channel.recv ( 1024 )
if not data: break # <<< ADD THIS

Or, as suggested by @sr2222, you can combine both this and your current check into one:

if not data or 'exit' in data:

This will exit the loop if the channel has been closed.

edited Nov 6, 2012 at 17:08

answered Nov 6, 2012 at 17:03

NPE

503k114 gold badges970 silver badges1k bronze badges

Sign up to request clarification or add additional context in comments.

4 Comments

Silas Ray Over a year ago

Or just if not data or 'exit' in data:

bryanvan Over a year ago

Wow damm I indeed missed this... couldnt wrap my head around it, both the answer of NPE and sr2222 are correct. THX

Silas Ray Over a year ago

Oh, sorry NPE, you are right, it's probably better to have 2 separate checks, since the 'exit' in data check sends data back over the connection, which will not be valid if data is empty.

NPE Over a year ago

@sr2222: Yes and no. AFAIK, calling send() on a closed channel is a no-op. However, some might question this approach on stylistic grounds.

Collectives™ on Stack Overflow

stuck in while loop python

1 Answer 1

4 Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

4 Comments

Your Answer

Sign up or log in

Post as a guest

Related