Passing variable in PHP link [duplicate]

Question

Possible Duplicate:
php - insert a variable in an echo string

I have a link that when it is clicked calls the next page and should pass two varibles to the page, the first is Manu and the second is fuel_type.

The problem is I can not seem to get the code to identify the variables and instead it passes the dollar sign and the variable name and not the value.

The code is below, i have tried writing this several different ways, but I am just running out of ideas.

 .'<a href=\act/manufacturer.php?manufacturer=$manu&fuel_type=$fuel_type>'.$manu.'</a>'.

You forgot to read the PHP documentation. The PHP manual quite clearly explains how variables are interpolated inside strings. In this case the difference between ' and " is key. Please go read the manual... — Lightness Races in Orbit
– Lightness Races in Orbit, Commented Nov 5, 2012 at 1:14

score 4 · Accepted Answer · 2012-11-05 01:54:59Z

4

First, be sure that the variables contain what you want (from the superglobal GET variable):

$manu = $_GET['manu'];
$fuel_type = $_GET['fuel_type'];

Then, you have two options:

Use double quotes " instead of single quotes, variables inside of quotes will be expanded
```
"My dog is named $dog_name, and is $dog_age years old";
```

Concatenate the strings inside single quotes with variables:

'My dog is named ' . $dog_name . ', and is ' . $dog_age . ' years old.';

Be absolutely certain, however that you sanitize the variables before using or displaying them to the browser. At a minimum, you want any HTML/JS code removed, then some checking to make sure the result is of the type and length that you expect. There are quite a few questions on SO discussing ways to do this, a quick search for [php] sanitize GET variables will turn them up.

edited Nov 5, 2012 at 1:54

answered Nov 5, 2012 at 1:24

user50049

Sign up to request clarification or add additional context in comments.

Comments

gabrielem · Accepted Answer · 2012-11-05 01:13:53Z

2

you have to insert the var outside the '

like this:

.'<a href=\act/manufacturer.php?manufacturer='.$manu.'&fuel_type='.$fuel_type.'>'.$manu.'</a>'.

answered Nov 5, 2012 at 1:13

gabrielem

5605 silver badges13 bronze badges

Comments

Daedalus · Accepted Answer · 2012-11-05 01:13:11Z

2

Single quotes do not parse variables, while double quotes do. Change your quotes around, and your link should work correctly.

Example:

."<a href=\act/manufacturer.php?manufacturer=$manu&fuel_type=$fuel_type>".$manu.'</a>'.

answered Nov 5, 2012 at 1:13

Daedalus

7,7125 gold badges40 silver badges64 bronze badges

Comments

nickhar · Accepted Answer · 2012-11-05 01:20:39Z

2

Single quotes dont allow parsing of variables, double-quotes do. So you'd be better off doing something like:

"<a href=\act/manufacturer.php?manufacturer=$manu&fuel_type=$fuel_type>$manu</a>";

-- or in your case --

'<a href=\act/manufacturer.php?manufacturer='.$manu.'&fuel_type='.$fuel_type.'>'.$manu.'</a>'

edited Nov 5, 2012 at 1:20

answered Nov 5, 2012 at 1:15

nickhar

21.1k12 gold badges64 silver badges77 bronze badges

2 Comments

gabrielem Over a year ago

this is the sum of mine and Daedalus's

nickhar Over a year ago

@gabrielem Yeah. Great minds...

Lock · Accepted Answer · 2012-11-05 01:16:34Z

-1

You can wrap your variables around curly braces to escape variable expressions:

'<a href=\act/manufacturer.php?manufacturer={$manu}&fuel_type={$fuel_type}>'.$manu.'</a>'.

answered Nov 5, 2012 at 1:16

Lock

5,53217 gold badges71 silver badges116 bronze badges

1 Comment

Daedalus Over a year ago

This however will not work.

Collectives™ on Stack Overflow

Passing variable in PHP link [duplicate]

5 Answers 5

Comments

Comments

Comments

2 Comments

1 Comment

Linked

Hot Network Questions

Collectives™ on Stack Overflow

5 Answers 5

Comments

Comments

Comments

2 Comments

1 Comment

Linked

Related