String formatting with commas in javascript

Question

Let's I have parts of user's address that should be formatted in single string.
Address components are

Street  
City  
Phone  
State  
Zip

and should be formatted to string street city, phone, state zip. (2 commas).
Problem is that every field can be null. So if street == null and city == null, then I should have string phone, state zip (1 comma). Problem is in controlling number of spaces and number of commas
How can I avoid and minimize the number of null-inspections?
My current code is

  var formatAddress = function(address) {
     var retVal = ""

     if (address.street || address.city)
     {
        retVal += address.street ? address.street + " " : "" 
        retVal += address.city ? address.city : "" 
        retVal += ", ";
     }
     retVal += address.phone ? address.phone + ", " : ""

     retVal += address.state ? address.state : ""
     retVal += address.zip ? " " + address.zip : ""  

     return retVal
  }

@jbabey I am finding another way to do this. I don't ask to refactor my code — Ilya
– Ilya, Commented Oct 25, 2012 at 14:36

Bergi · Accepted Answer · 2012-10-25 14:48:32Z

5

var fields = [[address.street, address.city], [address.phone], [address.state, address.zip]];
return fields.map(function(part) {
    return part.filter(Boolean).join(" ");
}).filter(function(str) { return str.length; }).join(", ");

Or, in a loop and without filter and map, but mapping property names to their values:

var fields = [["street", "city"], ["phone"], ["state", "zip"]];
for (var strs=[], i=0; i<fields.length; i++) {
    for (var parts=[], j=0; j<fields[i].length; j++)
        if (address[fields[i][j]])
            parts.push(address[fields[i][j]]);
    if (parts.length)
        strs.push(parts.join(" "));
}
return strs.join(", ");

edited Oct 25, 2012 at 14:48

answered Oct 25, 2012 at 14:43

Bergi

671k162 gold badges1k silver badges1.5k bronze badges

Sign up to request clarification or add additional context in comments.

Comments

red-X · Accepted Answer · 2012-10-25 14:38:46Z

1

add it to an array and remove some adjacent comma's and spaces.

var street = "street";
var city = "city";
var phone = "phone";
var state = "state";
var zip = "zip";
[
    street,
    city, ",",
    phone, ",",
    state,
    zip
].join(" ") //add all items with spaces in between
.replace(/(\s*,\s*)+/g, ", ") //remove multiple spaces before or after commas
.replace(/\s+/g, " "); //remove any other double spaces

answered Oct 25, 2012 at 14:38

red-X

5,1281 gold badge28 silver badges40 bronze badges

Comments

Francis P · Accepted Answer · 2012-10-25 14:37:15Z

0

Could be cleaner with a function:

function formatAddressPart(part,concatString){
     return part ? part+concatString : "";
}


var formatAddress = function(address) {
     var retVal = ""

     if (address.street || address.city)
     {
        retVal += formatAddressPart(address.street, " ");
        retVal += formatAddressPart(address.city,""); 
        retVal += ", ";
     }
     retVal += formatAddressPart(address.phone,", ");

     retVal += formatAddressPart(address.state," ");
     retVal += formatAddressPart(address.zip,"");  

     return retVal
  }

answered Oct 25, 2012 at 14:37

Francis P

13.7k3 gold badges30 silver badges52 bronze badges

Comments

HBP · Accepted Answer · 2012-10-25 15:09:35Z

0

Put your strings in an array, then use the join method and remove multipel consecutive commas with a single one

a = [address.Street, 
     address.City, 
     address.Phone, 
     address.State, 
     address.Zip].join (', ').replace (/(, ){2,}/g, ', ');

answered Oct 25, 2012 at 15:09

HBP

16.1k6 gold badges30 silver badges34 bronze badges

Collectives™ on Stack Overflow

String formatting with commas in javascript

4 Answers 4

Comments

Comments

Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

4 Answers 4

Comments

Comments

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related