codeigniter using function inside a controller

Question

For some reason I cant run the change() function and everything after it stops. I try with $this->change() but the effect is the same. If I run the function in a php file its working and the num is changing.

class Test extends CI_Controller {

    function __construct(){
        parent::__construct();
    }

    public function home(){

        $num = 1;

        change($num);


        function change($num,$rand=false){

            echo 'inside function'; // this is not shown

            if($num < 4) {
                $rand = rand(1,9);
                $num = $num.$rand;
                change($num,$rand);
            } else {
                echo $num;
            }
        }
        echo 'done'; // this is not shown

    }

}

also is num supposed to be a float int type? use '.' won't make that happen that is for string concatenation — Andre Dublin
– Andre Dublin, Commented Oct 19, 2012 at 15:57
just take the function outside.... it will work like a charm. — itachi
– itachi, Commented Oct 19, 2012 at 16:00

Andre Dublin · Accepted Answer · 2012-10-29 21:05:36Z

4

You will probably be better off calling a private or public function to process data ( or for more complex/involved processes a library ).

ie

class Test extends CI_Controller
{
  public function __construct()
  {
      parent::__construct();
  }

  public function home()
  {
    $num = 1;

    echo $this->_change($num);
    echo 'done'; // this is not shown
  }

  // private or public is w/o the underscore
  // its better to use private so that CI doesn't route to this function
  private function _change($num, $rand = FALSE)
  {
        if($num < 4) {
            $rand = rand(1,9);
            $num = $num + $rand;
            $this->_change($num,$rand);
        } else {
            return $num;
        }
  }
}

edited Oct 29, 2012 at 21:05

answered Oct 19, 2012 at 15:53

Andre Dublin

1,1581 gold badge16 silver badges34 bronze badges

Sign up to request clarification or add additional context in comments.

2 Comments

Aniket Over a year ago

agreed. this is a better implementation. a private function would actually do the trick.

Andre Dublin Over a year ago

fufu i updated the code, since you are using recursion make sure that your function is actually creating a stack by probably using die() or var_dump in the else clause.

Stan · Accepted Answer · 2012-10-19 15:52:33Z

3

lol, you are trying to write function inside function.

try running your class with this code

class Test extends CI_Controller {

    function __construct(){
        parent::__construct();
    }

    public function home(){

        $num = 1;

        $this->change($num);
        echo 'done'; // this is not shown

    }

    public function change($num,$rand=false){

            echo 'inside function'; // this is not shown

            if($num < 4) {
                $rand = rand(1,9);
                $num = $num.$rand;
                change($num,$rand);
            } else {
                echo $num;
            }
    }

}

answered Oct 19, 2012 at 15:52

Stan

26.7k55 gold badges169 silver badges248 bronze badges

Collectives™ on Stack Overflow

codeigniter using function inside a controller

2 Answers 2

2 Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

2 Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related