PHP Function using javascript / jquery hiding div

Question

I have a php function:

function myfunc() {

//then I have a div...

echo '<div class="overlay">';
echo "<button onclick=\"$('.overlay').hide();\">Close</button>";
echo '</div>';

}

My problem is that when I click on the close button the div is not hiding.

What I'm I doing wrong here?

your code is working correctly no problem in that check one again — Varun Sridharan
– Varun Sridharan, Commented Oct 18, 2012 at 9:44
You may need to escape the $, since it's inside a double-quoted string. — Barmar
– Barmar, Commented Oct 18, 2012 at 9:51

Fabrizio Calderan · Accepted Answer · 2012-10-18 09:41:38Z

5

Avoid to hardcode javascript handlers and inline events inside the output of php code: do instead

echo '<div class="overlay">';
echo "<button>Close</button>";
echo '</div>';

and previously insert in your page this code that detects a click on your button using event delegation

<script>
  $(document).on('click', '.overlay button', function() {
      $(this).parent().hide()
  });
</script>

answered Oct 18, 2012 at 9:41

Fabrizio Calderan

124k26 gold badges171 silver badges183 bronze badges

Sign up to request clarification or add additional context in comments.

3 Comments

Ram Over a year ago

button is child of overlay. Why event delegation?

Fabrizio Calderan Over a year ago

Sorry, misread the markup. Updated. I've used event delegation because AFAIK that could be the response of an ajax call (so the code could be injected later on DOM) and, as a general rule, if you have many elements to handle, this approach is better than attaching an handler on each element

Satch3000 Over a year ago

I tried the code above but it's just hiding the iside content of the div and the button but not the actual div

goncaloGomes · Accepted Answer · 2012-10-18 10:23:57Z

2

try:

<button onclick="this.parentNode.style.display = 'none'; return false;">Close</button>

edited Oct 18, 2012 at 10:23

answered Oct 18, 2012 at 9:42

goncaloGomes

16311 bronze badges

3 Comments

Satch3000 Over a year ago

Tried: echo '<button onclick=\"this.style.display = 'none'; return false;">Close</button>'; but the page goes blank so there's a syntax issues here?

Barmar Over a year ago

Since that's a single-quoted string, you need to escape single quotes, not double quotes, inside it.

goncaloGomes Over a year ago

Sorry, a bit irresponsible that I just posted without testing x| This one works now. It hides the parentNode which is the div.

VijayS91 · Accepted Answer · 2014-06-11 09:09:42Z

2

Try this code:

function myfunc() {

//then I have a div...

echo '<div class="overlay"  id="overlay" >';
echo "<button onclick=\"hide()\">Close</button>";
echo '</div>';

}
//using the javascript code:
function hide()
{
    document.getElementById("overlay").style.display="none";

}

edited Jun 11, 2014 at 9:09

answered Oct 18, 2012 at 9:51

VijayS91

1,53123 silver badges40 bronze badges

1 Comment

Satch3000 Over a year ago

Tried it but it didn't hide the div

Jaswinder Singh Narula · Accepted Answer · 2012-10-18 12:31:56Z

0

try:

$('.overlay button').live('click',function(
    $('.overlay').css({'display': 'none'});
));

answered Oct 18, 2012 at 12:31

Jaswinder Singh Narula

113 bronze badges

Collectives™ on Stack Overflow

PHP Function using javascript / jquery hiding div

4 Answers 4

3 Comments

3 Comments

1 Comment

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

4 Answers 4

3 Comments

3 Comments

1 Comment

Comments

Your Answer

Sign up or log in

Post as a guest

Related