How to implement .indexof for an array of strings?

Question

How can I simplify below code? How can I get rid of the if statements? I want to highlight some lines in ajax response. Right now I have two strings to compare = two ifs. This number will increase so I am thinking of doing this some other way - using an array of the strings that needs to be highlighted in case the string is part of data_array element.

I prefer a solution in javascript only but jQuery is ok too.

    data_array=data.split('<BR>');
    for(var i=0, len=data_array.length; i < len; i++){
        if (data_array[i].indexOf('Conflict discovered') >= 0){
            data_array[i]="<span class='red'>"+data_array[i]+"</span>";
        }   
        if (data_array[i].indexOf('Syntax error') >= 0){
            data_array[i]="<span class='red'>"+data_array[i]+"</span>";
        }   
    }
    data=data_array.join('<BR>');

@ibu - jquery != javascript. "but jQuery is ok too" implies solutions utilizing jQuery methods are acceptable — user578895
– user578895, Commented Oct 16, 2012 at 1:30

user578895 · Accepted Answer · 2012-10-16 01:53:05Z

3

Add more elements to the array as desired :)

data.replace( /<br>/ig, '\n' ).replace(
    new RegExp( '^(.*(?:' + [
          'Conflict discovered'
        , 'Syntax error'
    ].join( '|' ) + ').*)$', 'gm' )
, '<span class="red">$1</span>' ).replace( /\n/g, '<br>' );

explanation:

replace   tags with line breaks
make a regexp: ^(.*(?:Conflict discovered|Syntax error).*)$
surround matches with  ... 
turn line breaks back in to   tags

answered Oct 16, 2012 at 1:53

user578895

Sign up to request clarification or add additional context in comments.

15 Comments

Radek Over a year ago

Will this span the text from an array or the whole lot between  's?

Radek Over a year ago

Yes, it was desired. :-) But I couldn't figure it out from the code by myself. So I asked.

user578895 Over a year ago

yeah, that's what the ^(.* ... .*)$ is for, to match the whole line

Radek Over a year ago

Why did you have to replace with new lines? I guess I can replace ['Conflict discovered' ] with a variable name, can't I.

user578895 Over a year ago

because the ^ and $ match against beginning and end of lines. Without it, I'd need to overly complicate the regex to find entire lines between   tags. Yes, you can replace the [ ... ] with a variable. And yes, it's "one line" if that matters

|

Laurence · Accepted Answer · 2012-10-16 01:48:37Z

3

Why not add another for loop?

data_array=data.split('<BR>');

var stringsToFind = ['Conflict discovered', 'Syntax error'];

for (var i = 0; i < data_array.length; i++) {

    for (var j = 0; j < stringsToFind.length; j++) {

        var currItem = data_array[i];

        if (currItem.indexOf(stringsToFind[j]) >= 0) {

            data_array[i]='<span class="red">' + currItem + '</span>';
        }
    }  
}

data = data_array.join('<BR>');

jQuery (note, may be slower, and I haven't tested this yet)

data_array=data.split('<BR>');

var stringsToFind = ['Conflict discovered', 'Syntax error'];

$.each(data_array, function(i, item) {
    $.each(stringsToFind, function(j, s) {
        if (item.indexOf(s) >= 0) {
            data_array[i]='<span class="red">' + item + '</span>';
        }
    }
});

data = data_array.join('<BR>');

edited Oct 16, 2012 at 1:48

answered Oct 16, 2012 at 1:35

Laurence

1,71311 silver badges16 bronze badges

6 Comments

Androiderson Over a year ago

In addition to that, I would use jQuery.each which is a nicer form of iteration.

Laurence Over a year ago

@Anderson Silva: True, but this would be the pure javascript solution if Radek doesn't want the jQuery library.

Radek Over a year ago

Could you add sample of .each to you answer so I'll accept it?

Insidi0us Over a year ago

@Radek Check my answer which doesn't use any loops

Radek Over a year ago

Yes, but I like yours the best. Sorry @Laurence.

|

Insidi0us · Accepted Answer · 2012-10-16 01:51:40Z

2

var data_array = data.split('<BR>');
var errMsgs = ['Conflict discovered', 'Syntax error'];
data_array = data_array.map(function(data_rec) {
    var isAnError = errMsgs.some(function (errMsg) {
        return data_rec.indexOf(errMsg) >= 0;
    });
    if (isAnError) {
        return "<span class='red'>" + data_rec + '</span>';
    } else {
        return data_rec;
    }
});

edited Oct 16, 2012 at 1:51

answered Oct 16, 2012 at 1:45

Insidi0us

1,1269 silver badges17 bronze badges

3 Comments

Laurence Over a year ago

+1 I didn't even know about some. This is a really good solution, @Insidi0us

Ja͢ck Over a year ago

some() is pretty new, see here for a JS equivalent: developer.mozilla.org/en-US/docs/JavaScript/Reference/…

Laurence Over a year ago

Oh, but you should note that this is IE9 and all modern browsers only, according to developer.mozilla.org/en-US/docs/JavaScript/Reference/…

Roko C. Buljan · Accepted Answer · 2012-10-16 02:25:58Z

1

jsBin demo

var highlightWords = ['Conflict discovered', 'Syntax error', 'Simply cool'];

for(i=0; i<highlightWords.length; i++){
  var regex = new RegExp(highlightWords[i],'ig');
  data= data.replace( regex, '<span class="red">'+ highlightWords[i] +'</span>');
}

$('div').html( data );

jsBin demo 2 all line highlight

var words = ['Conflict discovered', 'Syntax error', 'Strange'];
var data_array=data.split('<BR>');

for(n=0;n<words.length;n++){
  for(i=0; i<data_array.length; i++){
      if (data_array[i].indexOf( words[n] ) >= 0){
           data_array[i]="<span class='red'>"+data_array[i]+"</span>";
      }   
  }
  data = data_array.join('<BR>');
}

$('div').html( data );

edited Oct 16, 2012 at 2:25

answered Oct 16, 2012 at 1:48

Roko C. Buljan

209k41 gold badges335 silver badges346 bronze badges

3 Comments

Radek Over a year ago

Your code highlights the (error) string only. Mine the whole line defined from to . I like it though. I learnt something new.

Radek Over a year ago

I like your solution very much too. Actually it is probably easier to read than @cwolves' one.

Roko C. Buljan Over a year ago

@Radek Thanks! I'm glad was helpful!

JCOC611 · Accepted Answer · 2012-10-16 01:30:37Z

0

data_array=data.split('<BR>');
for(var i=0, len=data_array.length; i < len; i++){
    var dai = data_array[i];
    if (dai.indexOf('Conflict discovered') >= 0 || dai.indexOf('Syntax error') >= 0){
        data_array[i] = "<span class='red'>"+dai+"</span>";
    }   
}
data=data_array.join('<BR>');

answered Oct 16, 2012 at 1:30

JCOC611

19.8k15 gold badges71 silver badges90 bronze badges

2 Comments

Radek Over a year ago

Yes :-) but wouldn't be easier to have an array that I modify instead of introducing new if or or? I have one config file that I would like such array to have in.

jonvuri Over a year ago

@Radek, check out .map and .forEach

Collectives™ on Stack Overflow

How to implement .indexof for an array of strings?

5 Answers 5

15 Comments

6 Comments

3 Comments

jsBin demo

jsBin demo 2 all line highlight

3 Comments

2 Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

5 Answers 5

15 Comments

6 Comments

3 Comments

3 Comments

2 Comments

Your Answer

Sign up or log in

Post as a guest

Related