php preg match some url in javascript

Question

there have some links, some are in javascript code. how to preg match there urls? (the urls could be end by .shtml, .html, / or .jsp, so I think regex them in single quotes, but nothing return.)

$sitelink = "javascript:pre('http://www.domain.com/cotagory/articles/2012/09/23/notice.shtml',%20%,500)";
//$sitelink = "javascript:box('http://www.domain.com/cotagory/articles/2012/09/23/sports/',%18%,500)";
if(strpos($sitelink,'javascript')===true){
    preg_match_all("@'(.*)'@i",$sitelink,$matches);
    var_dump($matches);
}

Toto · Accepted Answer · 2012-09-24 08:49:49Z

1

Change the if condition to:

if(strpos($sitelink,'javascript') !== false){

The position of 'javascript' within $sitelink is 0 that is not true!!!

edited Sep 24, 2012 at 8:49

answered Sep 24, 2012 at 8:39

Toto

91.7k63 gold badges97 silver badges135 bronze badges

Sign up to request clarification or add additional context in comments.

2 Comments

Ja͢ck Over a year ago

This will always yield true because strpos() never returns -1

Ja͢ck Over a year ago

Still think matching 'javascript' at the start of the string is better, but since OP never stated this behaviour explicitly I'll revert the DV

Ja͢ck · Accepted Answer · 2012-09-24 08:47:04Z

1

The logic of matching 'javascript' at the start of the string is wrong; it should be:

strpos($sitelink, 'javascript') === 0

The regular expression could also be a little nicer:

preg_match("@'([^']*)'@", $sitelink, $matches);

answered Sep 24, 2012 at 8:47

Ja͢ck

174k39 gold badges269 silver badges316 bronze badges

Collectives™ on Stack Overflow

php preg match some url in javascript

2 Answers 2

2 Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

2 Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related