jQuery Replacing, Using arrays

Question

var searchp   = $('body'),
    searchval = searchp.html(),
    name      = ['Abraham Lincoln', 'George Washington'];
    cname     = name.toLowerCase().replace(/ /g, ''),
    restr     = searchval.split(name).join('<a href="#" data-name="'+cname+'">'+name+'</a>');

searchp.html( replacestr );

I need some help with a litte replace function. It works fine if I use name= 'string name', but I can't get it to work with arrays. Hopefully you can help me.

The split/join technique to replace all occurences only works for a string. If you want to use an array, you'll have to loop. — pimvdb
– pimvdb, Commented Sep 9, 2012 at 15:03
FYI, you have a ; after the Array which makes cname and restr global variables. I prefer to use leading commas on each line (below the var) instead of trailing commas to make it very clear that all the commas are present. — gray state is coming
– gray state is coming, Commented Sep 9, 2012 at 15:14

nuala · Accepted Answer · 2012-09-09 15:07:56Z

1

You try to call toLowerCase() on an Array which provides no toLowerCase() method. Instead you should specify an item in that array like:

cname     = name[0].toLowerCase().replace(/ /g, ''),

This is easy to spot of you open the console of your browser as running it in Chrome gave me this message:

Uncaught TypeError: Object Abraham Lincoln,George Washington has no method 'toLowerCase'

As comments on your questions indicate you probably don't want to hard code the index of the element but instead use a loop. I tried to fiddle around with your code but it seems some input from #body is missing to get some semantic in your lines so all I can provide is one suggestion how to loop over an array of srings:

var name = ['Abraham Lincoln', 'George Washington'];
$(name).each(function(key, value){
    console.log(value.toLowerCase());
});

edited Sep 9, 2012 at 15:07

answered Sep 9, 2012 at 15:00

nuala

2,6894 gold badges33 silver badges54 bronze badges

Sign up to request clarification or add additional context in comments.

1 Comment

Bastian Hofmann Over a year ago

Thank you very much. I got it working, but I placed the replacestr variable inside the each function, so it get overwritten, by the second array item. Other than that it works. Also I changed this: var replacestr = searchval.replace(regexname, '<a href="#" data-name="'+cname+'" class="vcard-call">'+name+'</a>');

Collectives™ on Stack Overflow

jQuery Replacing, Using arrays

1 Answer 1

1 Comment

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

1 Comment

Your Answer

Sign up or log in

Post as a guest

Related