Java, How to add an object into LinkedList?

Question

I have written following lines of code and seems everything is OK, however when I see result its not correct.

Here, I defined a LinkedList and adding an object into it.

private LinkedList<KategoriRecipeList> createListObjects() {

        LinkedList<KategoriRecipeList> list = new LinkedList<KategoriRecipeList>();
        KategoriRecipeList kategori = new KategoriRecipeList();

        for(int i=0; i<resepi.getResepiId().size(); i++) {
            kategori.setKategoriName(kategoriName);
            kategori.setResepiId(resepi.getResepiId().get(i));
            kategori.setResepiName(resepi.getResepiName().get(i).trim().replaceAll("'", ""));
            kategori.setImgLogoUri(resepi.getResepiImageURL().get(i));
            kategori.setImgMoreUri(bitmapUrls.get(i));

            Log.i("WWWWWWW", "Recipe '" + resepi.getResepiName().get(i) + "' added to list");

            list.add(kategori);
        }

        return list;
    }

When I see Log file the result is like this:

09-09 03:05:29.272: I/WWWWWWW(1250): Recipe '"Chicken Cordon Bleu"' added to list

09-09 03:05:29.272: I/WWWWWWW(1250): Recipe '"Sat-Bag"' added to list

09-09 03:05:29.272: I/WWWWWWW(1250): Recipe 'Ayam Adobo ' added to list

09-09 03:05:29.272: I/WWWWWWW(1250): Recipe 'Ayam Ber’Crumble’ & ‘Fennel’ direneh Air Roselle' added to list

09-09 03:05:29.272: I/WWWWWWW(1250): Recipe 'Ayam Dua Cara' added to list

I have another method which invokes above method:

private void storeListIntoDatabase() {
        Log.i(TAG, "Try to insert data into database.");

        LinkedList<KategoriRecipeList> listOfObjects = createListObjects();
        if(listOfObjects == null  ||  listOfObjects.size() <= 0)
            return;

        for(int i=0;  i<listOfObjects.size(); i++)
            Log.i("KKKKKKKK", "Recipe '" + listOfObjects.get(i).getResepiName() + "' added to list");
    }

Result in log file is like this:

09-09 03:05:29.297: I/KKKKKKKK(1250): Recipe 'Tongkeng Ayam Goreng dan Nasi Kari Leher Ayam' added to list

09-09 03:05:29.297: I/KKKKKKKK(1250): Recipe 'Tongkeng Ayam Goreng dan Nasi Kari Leher Ayam' added to list

09-09 03:05:29.297: I/KKKKKKKK(1250): Recipe 'Tongkeng Ayam Goreng dan Nasi Kari Leher Ayam' added to list

09-09 03:05:29.297: I/KKKKKKKK(1250): Recipe 'Tongkeng Ayam Goreng dan Nasi Kari Leher Ayam' added to list

09-09 03:05:29.297: I/KKKKKKKK(1250): Recipe 'Tongkeng Ayam Goreng dan Nasi Kari Leher Ayam' added to list

As you can see results are different but i expect result should be same. Where is my problem? Thanks

Isn't the result already the same?

quantum
– quantum

2012-09-08 19:22:57 +00:00
Commented Sep 8, 2012 at 19:22 — quantum
– quantum, Commented Sep 8, 2012 at 19:22

Frank Pavageau · Accepted Answer · 2012-09-08 19:44:51Z

3

You need to create new instance on each loop otherwise same instance will be updated. Lists maintains reference to object, they don't contain copy of the object.

for(int i=0; i<resepi.getResepiId().size(); i++) {
    KategoriRecipeList kategori = new KategoriRecipeList();
    kategori.setKategoriName(kategoriName);
    kategori.setResepiId(resepi.getResepiId().get(i));
    ....
}

edited Sep 8, 2012 at 19:44

Frank Pavageau

11.7k1 gold badge45 silver badges54 bronze badges

answered Sep 8, 2012 at 19:22

kosa

66.7k15 gold badges134 silver badges170 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

yael alfasi · Accepted Answer · 2012-09-08 19:22:58Z

2

this line

KategoriRecipeList kategori = new KategoriRecipeList();

needs to be inside the for loop you have to create a new object every time

answered Sep 8, 2012 at 19:22

yael alfasi

6821 gold badge5 silver badges13 bronze badges

Collectives™ on Stack Overflow

Java, How to add an object into LinkedList?

2 Answers 2

Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related