Set MySQL field from php variable

Question

I have a variable $Altgeraet it contains "OK" or "NOK".

I have an mysql field called Status_Altgeraet in the table zuordnung. So now I want to UPDATE or SET the field based on the variable.

This is what I tried:

$sql_Update = "UPDATE zuordnung SET Status_Altgeraet = ".$Altgeraet"";  
mysql_query($sql_Update);

Can you give me tips how to solve this? I'm a php beginner.

Don't build SQL by mashing strings together. Use prepared statements / bound variables. — Quentin
– Quentin, Commented Sep 3, 2012 at 8:36
Don't use mysql_query, it has a big red warning box on the manual page for a reason. — Quentin
– Quentin, Commented Sep 3, 2012 at 8:37

Fluffeh · Accepted Answer · 2012-09-03 08:33:01Z

3

You missed quotes around the string input and a . concat at the end of your line:

$sql_Update = "UPDATE zuordnung SET Status_Altgeraet = '".$Altgeraet."'";

answered Sep 3, 2012 at 8:33

Fluffeh

33.6k16 gold badges69 silver badges80 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

Asciiom · Accepted Answer · 2012-09-03 08:38:42Z

2

You're missing a dot there and also quotes around the string you're trying to set the column value to (as Fluffeh mentioned the comments), try this:

$sql_Update = "UPDATE zuordnung SET Status_Altgeraet = '".$Altgeraet."'";  
mysql_query($sql_Update);

These days, prepared statements are probably the way to go, you should look into that.

edited Sep 3, 2012 at 8:38

answered Sep 3, 2012 at 8:33

Asciiom

9,9757 gold badges42 silver badges59 bronze badges

1 Comment

Fluffeh Over a year ago

The variable is also a string, so needs to be encapsulated in quotes.

Vipin Jain · Accepted Answer · 2012-09-03 08:35:34Z

0

Your current statement will lead you to set the same value to all rows of the table.

So better use the where clause in the query,

And one more thing is that the string values should be sent in query wrapped in single quotes.

See this

$sql_Update = "UPDATE zuordnung SET Status_Altgeraet = '{$Altgeraet}' WHERE id={$someid}";

HERE $someid is the variable which contains the unique identifier for the row to be updated.

or you can use combinations of 'AND' and 'OR' for more conditions to select the rows you wish to update.

EDIT

and id is integer type so do not needs to be wrapped in the single quotes. but you can always wrap integer in single quotes also.

answered Sep 3, 2012 at 8:35

Vipin Jain

1,4021 gold badge12 silver badges20 bronze badges

Collectives™ on Stack Overflow

Set MySQL field from php variable

3 Answers 3

Comments

1 Comment

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

3 Answers 3

Comments

1 Comment

Comments

Your Answer

Sign up or log in

Post as a guest

Related