JavaScript regexp not matching

Question

I am having a difficult time getting a seemingly simple Regexp. I am trying to grab the last occurrences of word characters between square brackets in a string. My code:

pattern = /\[(\w+)\]/g;
var text = "item[gemstones_attributes][0][shape]";
if (pattern.test(text)) {
    alert(RegExp.lastMatch);
}

The above code is outputting "gemstones_attributes", when I want it to output "shape". Why is this regexp not working, or is there something wrong with my approach to getting the last match? I'm sure that I am making an obvious mistake - regular expressions have never been my string suit.

Edit: There are cases in which the string will not terminate with a right-bracket.

midgetspy · Accepted Answer · 2012-08-22 06:04:15Z

2

You can greedily match as much as possible before your pattern which will result in your group matching only the last match:

pattern = /.*\[(\w+)\]/g;
var text = "item[gemstones_attributes][0][shape]";
var match = pattern.exec(text);
if (match != null) alert(match[1]);

answered Aug 22, 2012 at 6:04

midgetspy

6891 gold badge5 silver badges9 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

dave · Accepted Answer · 2012-08-22 06:05:40Z

1

RegExp.lastMatch gives the match of the last regular expression. It isn't the last match in the text.

Regular expressions parse left to right and are greedy. So your regexp matches the first '[' it sees and grabs the words between it. When you call lastMatch it gives you the last pattern matched. What you need is to match everything you can first .* and then your pattern.

answered Aug 22, 2012 at 6:05

dave

4,9424 gold badges29 silver badges39 bronze badges

1 Comment

Andrew Over a year ago

Thanks for the explanation. This was the first time I have worked with a regexp in JavaScript, so I have no clue how differently they are implemented than the Perl-style regexp.

retinotop · Accepted Answer · 2012-08-22 06:09:15Z

0

i think your problem is in your regex not in your src line .lastMatch.

Your regex returns just the first match of your square brackets and not all matches. You can try to add some groups to your regular expression - and normally you should get all matches.

krikit

answered Aug 22, 2012 at 6:09

retinotop

48311 silver badges18 bronze badges

Comments

Dr.Molle · Accepted Answer · 2012-08-22 06:13:12Z

0

Use match() instead of test()

if (text.match(pattern))

test() checks for a match inside a string. This is successfull after the first occurence, so there is no need for further parsing.

edited Aug 22, 2012 at 6:13

answered Aug 22, 2012 at 6:08

Dr.Molle

117k16 gold badges200 silver badges206 bronze badges

Collectives™ on Stack Overflow

JavaScript regexp not matching

4 Answers 4

Comments

1 Comment

Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

4 Answers 4

Comments

1 Comment

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related