display contents of PHP Mysql Array

Question

Simple question (I think).

I have the below PHP / MySQL script:

$risksql="select risk from jobsrisks where job='$job'";
$executerisks=mysql_query($risksql);
$test=mysql_fetch_array($executerisks);
$riskrows=mysql_num_rows($executerisks);

I want to print the values of the array (for testing), with code:

print_r($test);

This produces the below output:

The query, in php actually outputs 3 records, not just one that is repeated. Any ideas whay I am doing incorrectly? where are the other records and why not in the array? is mysql_fetch_array the correct code to use?

I then want to then use the PHP array in another mysql query:

$ids = join(',',$test);   
$sql = "SELECT * FROM table WHERE risk IN ($ids)";

Would this then be correct?

Help is appreciated as always.

Thanks, R

It may not help answer your question, but you should stop using mysql_* functions. They're being deprecated. Instead use PDO (supported as of PHP 5.1) or mysqli (supported as of PHP 4.1). If you're not sure which one to use, read this article. — Matt
– Matt, Commented Aug 14, 2012 at 14:05
If there was ever a job risk it's using mysql_query. This kind of code will eventually get you fired. — tadman
– tadman, Commented Aug 14, 2012 at 14:22

pomaxa · Accepted Answer · 2012-08-14 14:03:46Z

2

you need to fetch each row, ie:

while ($row = mysql_fetch_assoc($result)) {
    echo $row['firstname'];
    echo $row['lastname'];
    echo $row['address'];
    echo $row['age'];
}

check the manual

$ids = join(',',$test);   
$sql = "SELECT * FROM table WHERE risk IN ('$ids')";

almost right. don't forget about quotes

answered Aug 14, 2012 at 14:03

pomaxa

1,74616 silver badges26 bronze badges

Sign up to request clarification or add additional context in comments.

2 Comments

tadman Over a year ago

Quotes don't matter. SQL escaping does.

pomaxa Over a year ago

$ids = join(',',$test); $sql = "SELECT * FROM table WHERE risk IN ($ids)"; - in first it won't work because of <'>; - and yes, you are right; there must be escaping, like mysql_real_escape. And even more, it is better to use PDO. to be more secure, if for some reason PDO is not an option, at least use mysqli drive instead of mysql;

Mihai Iorga · Accepted Answer · 2012-08-14 14:04:31Z

0

why not join the selects?

$sql = "SELECT * FROM table WHERE risk IN (SELECT risk FROM jobsrisks WHERE job='$job')";

answered Aug 14, 2012 at 14:04

Mihai Iorga

39.8k17 gold badges109 silver badges109 bronze badges

Collectives™ on Stack Overflow

display contents of PHP Mysql Array

2 Answers 2

2 Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

2 Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related