Setting HTML textbox value using javascript function?

Question

I'm using this code to set the HTML textbox value using Javascript function. But it seems to be not working. Can anyone point out, what is wrong with this code?

Whats your Name?
<input id="name" value="" />

<script type="text/javascript"> 
function setValue(value){
var myValue=value;
document.getElementsById("name").value = myValue;
}
</script>

the "value" is came from my android java class using this codes

String value = "Isiah";
    WebView web = (WebView) findViewById(R.id.web1);
    web.getSettings().setJavaScriptEnabled(true);
    web.loadUrl("file:///android_asset/www/webpage");
    web.loadUrl("javascript:setValue("+ value +")");

What's with the extra " after \"Javascript\"> ? (and the backslashes) — irrelephant
– irrelephant, Commented Aug 2, 2012 at 4:01
First you store the value passed to the function in a var (unnecessary) then try to overwrite it with a DOM element's value and do nothing more. I said "try" because getElementsByName returns a HTMLCollection and not a DOM element, let alone you don't have any element with that name. Use getElementById instead. Also, you don't ever call the function. It'd be better if you explicitly tell us what you're expecting your function to do. — Fabrício Matté
– Fabrício Matté, Commented Aug 2, 2012 at 4:03
You have a typo. getElementsById should be getElementById (without the extra s). Also the function is never called. — Fabrício Matté
– Fabrício Matté, Commented Aug 2, 2012 at 4:12

Sid M · Accepted Answer · 2014-09-04 06:58:54Z

7

   function setValue(value) {
    var myValue=value; //unnecessary
    document.getElementById("name").value= myValue;
}

But then as pointed out in the comments, you need to call setValue(value) somewhere in your code. Right now you just defined the function is never called.

edited Sep 4, 2014 at 6:58

Sid M

4,3744 gold badges33 silver badges51 bronze badges

answered Aug 2, 2012 at 4:14

Hazem Salama

15.2k5 gold badges29 silver badges31 bronze badges

Sign up to request clarification or add additional context in comments.

2 Comments

user1570222 Over a year ago

how can I call it without using a button?

Hazem Salama Over a year ago

You can use a button/link/or just call the function on page load. Depends on when you want the box to be filled. When do you want this to happen?

Venkatesh S · Accepted Answer · 2012-08-02 04:22:48Z

1

You could either access the element’s value by its name:

  document.getElementsByName("textbox1"); // returns a list of elements with name="textbox1"
    document.getElementsByName("textbox1")[0] // returns the first element in DOM with name="textbox1"

So:

    input name="buttonExecute" onclick="execute(document.getElementsByName('textbox1')[0].value)" type="button" value="Execute" />

Or you assign an ID to the element that then identifies it and you can access it with getElementById:

    <input name="textbox1" id="textbox1" type="text" />
    <input name="buttonExecute" onclick="execute(document.getElementById('textbox1').value)" type="button" value="Execute" />

answered Aug 2, 2012 at 4:22

Venkatesh S

5,5021 gold badge27 silver badges30 bronze badges

Comments

Ahsan Khurshid · Accepted Answer · 2012-08-02 04:14:29Z

0

You are using document.getElementsById("name") it should be document.getElementById("name")

not Elements it is Element

answered Aug 2, 2012 at 4:14

Ahsan Khurshid

9,4671 gold badge35 silver badges53 bronze badges

Comments

Roger · Accepted Answer · 2012-08-02 04:31:09Z

0

You are not linking the function to anything. For example, a click:

<input id="name" value="" onclick="javascript:this.value=12;"/>

Replace the onclick attribute for your desired function, whatever it does (you need to be more specific)

Also, there is no language attribute (at least not anymore) use type="text/javascript" instead

Here is a fiddle: http://jsfiddle.net/4juEp/

Click the input to see it working.

Look at this second fiddle. http://jsfiddle.net/4juEp/1/

which loads whatever is defined in the hid input to the name input.

edited Aug 2, 2012 at 4:31

answered Aug 2, 2012 at 4:10

Roger

2,9624 gold badges32 silver badges40 bronze badges

6 Comments

user1570222 Over a year ago

how can I call it without using a button?

Roger Over a year ago

@user1570222 I've never used Android (I plan to but I don't know any of it right now) See the link I updated to the answer, hope that it helps, as I said, you need call the function from somewhere. Take a lesson on javascript youtube.com/watch?v=v2ifWcnQs6M

Roger Over a year ago

@user1570222 Well, what exactly do you need? execute it when the page is loaded?

Roger Over a year ago

@user1570222 and where from do you take the input to the function? myValue in your example.

user1570222 Over a year ago

myValue = value. "value" is came from my android java class

|

Mahendra Liya · Accepted Answer · 2012-08-02 04:36:08Z

0

Firstly, you have a typo in your javascript function i.e. you have used getElementsById as compared to getElementById

To set the value of the textbox on page load, I suggest you use an alternative

<body onload="setValue('yourValueToSet');">

<!-- Your usual html code in the html file -->

</body>

answered Aug 2, 2012 at 4:36

Mahendra Liya

13.3k14 gold badges94 silver badges115 bronze badges

Comments

code-jaff · Accepted Answer · 2012-08-02 04:45:38Z

0

I think you are missing the quotes,

try,

web.loadUrl("javascript:setValue('"+ value +"')");

also consider about the typo.

answered Aug 2, 2012 at 4:45

code-jaff

9,3284 gold badges38 silver badges56 bronze badges

3 Comments

user1570222 Over a year ago

I edited it to web.loadUrl("javascript:setValue('"+ value +"')"); still undefined

code-jaff Over a year ago

i'm not sure whether you are missing the html extension at the end of web.loadUrl("file:///android_asset/www/webpage"); or try web.loadUrl("javascript:setValue(\""+ value +"\")");

user1570222 Over a year ago

I already change it like what you said but still its undefined

Automate This · Accepted Answer · 2014-04-02 01:06:22Z

0

Check this out:

<body onload="setvalue($value);">
Whats your Name?<input id="name" name="name" value=""/>
<script type="text/javascript">
function setValue(value){
document.{formname}.name.value = value;}</script>

edited Apr 2, 2014 at 1:06

Automate This

31.5k11 gold badges63 silver badges85 bronze badges

answered Apr 2, 2014 at 0:45

Sagar V

12.5k8 gold badges46 silver badges71 bronze badges

Comments

Nico O · Accepted Answer · 2014-03-23 10:26:38Z

-1

It's not Elements It's Element

You should use document.getElementById('object-id');

edited Mar 23, 2014 at 10:26

Nico O

14.2k10 gold badges58 silver badges71 bronze badges

answered Mar 23, 2014 at 10:03

user3451875

1

1 Comment

Sanoob Over a year ago

Try to elaborate your answer. Like giving code or documentation etc.

Collectives™ on Stack Overflow

Setting HTML textbox value using javascript function?

8 Answers 8

2 Comments

Comments

Comments

6 Comments

Comments

3 Comments

Comments

1 Comment

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

8 Answers 8

2 Comments

Comments

Comments

6 Comments

Comments

3 Comments

Comments

1 Comment

Your Answer

Sign up or log in

Post as a guest

Related