Return results from mysql, using user functions

Question

Please tell, why this code is wrong?

function myres () {
   $db = new mysqli("localhost","userrr","pass","mvc");
   $res = $db->query("SELECT * FROM news ");
   return $res;
}


while ($row = myres()->fetch_row()) {
    echo  $row[0];
}

P.S. this code is working:

$db = new mysqli("localhost","userrr","pass","mvc");
$res = $db->query("SELECT * FROM news ");
while ($row = $res->fetch_row()) {
    echo  $row[0];
}

Your myres() is executed each time the while condition is checked. If you extract it to a variable before the while loop, it will work better. — user1233508
– user1233508, Commented Jul 28, 2012 at 15:59
Why don't you just take the query out of the function, or have it return an array and do a foreach? — David
– David, Commented Jul 28, 2012 at 15:59

Danil Speransky · Accepted Answer · 2012-07-28 16:06:58Z

2

Here you call myres() every time, I think:

while ($row = myres()->fetch_row()) {
  echo  $row[0];
}

So every time $row contain first row of the result, and it will not stop. It will works fine, I think:

$res = myres();

while ($row = $res->fetch_row()) {
  echo  $row[0];
}

edited Jul 28, 2012 at 16:06

answered Jul 28, 2012 at 16:00

Danil Speransky

30.5k6 gold badges70 silver badges78 bronze badges

Sign up to request clarification or add additional context in comments.

2 Comments

David Over a year ago

This is not an answer, and would be more-suitable as a comment.

Jared Farrish Over a year ago

This lends credence to the idea it's being called new each time: codepad.org/9DeSMUvu

Collectives™ on Stack Overflow

Return results from mysql, using user functions

1 Answer 1

2 Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

2 Comments

Your Answer

Sign up or log in

Post as a guest

Related