arguments to javascript callback function

Question

var data = [{offset: 2000, str:'foo'}, {offset: 4000, str:'bar'}];

for (var i=0; i<data.length; i++) {
    var x = data[i];
    setTimeout(function(){printStuff(x.str)}, x.offset);
}

function printStuff(str) {
    console.log(str);
}

I was expecting to get printStuff('foo') at 2000 ms offset and printStuff('bar') at 4000 ms offset but instead it prints 'bar' both times. I've no idea what's going on, help please.

it's a scoping issue; when your printStuff finally runs, x has been reassigned to {offset:4000,str:'bar'} — jackwanders
– jackwanders, Commented Jul 6, 2012 at 14:22

Esailija · Accepted Answer · 2012-07-06 14:36:39Z

3

Do this :

for (var i = 0; i < data.length; i++) {
    (function (x) {
        setTimeout(function () {
            printStuff(x.str)
        }, x.offset);
    })(data[i]);
}

Your problem is that x has changed in the closure when the function is called.

edited Jul 6, 2012 at 14:36

Esailija

140k24 gold badges280 silver badges328 bronze badges

answered Jul 6, 2012 at 14:19

Denys Séguret

384k90 gold badges813 silver badges779 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

Esailija · Accepted Answer · 2012-07-06 14:24:03Z

2

You can use functional iteration that gives a closure for free:

data.forEach( function( x ) {
      setTimeout( printStuff.bind(null, x.str), x.offset );
});

Shims for all in case oldIE support is required:

forEach

bind

answered Jul 6, 2012 at 14:24

Esailija

140k24 gold badges280 silver badges328 bronze badges

2 Comments

Denys Séguret Over a year ago

I didn't knew this new and interesting function. Do you have precision about the compatibility (including mobiles) ?

Esailija Over a year ago

@dystroy the compatibility and user-made code to make those functions work in unsupported browsers can be found in the links I gave. Roughly any browser made/patched after december 2009 should support them.

Brett Zamir · Accepted Answer · 2012-07-06 14:24:08Z

0

setTimeout does not block the code from continuing to execute, so the loop completes, and by the time the setTimeout callback is executed, the latest value for 'x' is the second object in the data array.

answered Jul 6, 2012 at 14:24

Brett Zamir

14.4k7 gold badges57 silver badges85 bronze badges

Collectives™ on Stack Overflow

arguments to javascript callback function

3 Answers 3

Comments

2 Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

3 Answers 3

Comments

2 Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related