Getting an undefined offset in my PHP array while in a foreach

Question

I need some help, even though I think I'm checking for the length of the array and I should be breaking out of the loop, I still get warnings on my [else if ($value....] line. So either I'm missing something crucial or I've been staring at this code segment too long and its obvious. Any insight would be appreciated.

    $count = count($filter); //Filter is an array
    if ($count > 1 ){
        //Compare values and generate a range to choose from
        $i = 1;
        foreach($filter as $value){
            //Break the loop if at the end of the array
            if ($i >= $count){
                //throw new exception($i .' '.$count);
                break;
            }
            //if the value is smaller then the next procceding value, because they are already in order of presidence,
            //add it to our range of potentials.
            else if($value < $filter[$i]->value){
                array_push($range, key($filter));
            }
        $i++;
        }           
    }else {
        return false;
    }

Show the output of var_dump($filter);. If there are any gaps in your array or if it's an associative array (string indexes), this will happen. — Travesty3
– Travesty3, Commented Jun 11, 2012 at 18:44
Notice: Undefined offset: 1 in //yadada file// line # - but the answers were right. My keys aren't sequential, derp. Thanks guys. — dbergunder
– dbergunder, Commented Jun 11, 2012 at 19:49

Travesty3 · Accepted Answer · 2012-06-11 18:52:41Z

1

I suspect that there are gaps in your array. Try this:

$filter = array_values($filter); // this will remove any gaps in the array
$count = count($filter);
if ($count <= 1)
    return false;

for ($i = 0; $i < $count; $i++)
{
    if ($i != $count-1 && $filter[$i]->value < $filter[$i+1]->value)
        array_push($range, key($filter));
}

answered Jun 11, 2012 at 18:52

Travesty3

14.5k7 gold badges64 silver badges103 bronze badges

Sign up to request clarification or add additional context in comments.

1 Comment

dbergunder Over a year ago

Thanks, I should have known better.

Jannie Theunissen · Accepted Answer · 2012-06-11 19:20:15Z

1

Your array might have non-numeric keys. Then try this:

foreach($filter as $key=>$value)
{
   // test for $filter[$key];
}

Or your $filter array doesn't hold objects, then you can't use the -> in

$filter[$key]->value

answered Jun 11, 2012 at 19:20

Jannie Theunissen

30.3k21 gold badges110 silver badges136 bronze badges

Comments

Habeeb · Accepted Answer · 2012-06-11 18:53:28Z

0

try this code.... no need of checking count..

$range = array();
$i = 1;
foreach($filter as $value)
{
    if(isset($filter[$i]) && $value < $filter[$i]->value)
    {
        array_push($range, key($filter));
        $i++;
    }
    else
    {
        break;
    }
}

answered Jun 11, 2012 at 18:53

Habeeb

16613 bronze badges

2 Comments

dbergunder Over a year ago

I like this answer, but my derp moment was pointed out earlier though. So you have my thanks.

Travesty3 Over a year ago

If you don't check count, then on the last iteration, you will be comparing the last entry in the array with an undefined index of the array. That's why, in his example, he checks if ($i >= $count) { break; }.

Collectives™ on Stack Overflow

Getting an undefined offset in my PHP array while in a foreach

3 Answers 3

1 Comment

Comments

2 Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

3 Answers 3

1 Comment

Comments

2 Comments

Your Answer

Sign up or log in

Post as a guest

Related