PHP if/else statement issue

Question

I'm having some issues with this statement,

<?php 
    $cert_mess = $vehicle['make'];
    if ($vehicle["make"] == "Honda" && $vehicle["Certified"] == "0")  {
        $cert_mess = "DFWCertAutos";
    }
    elseif ($vehicle["make"] == "Cadillac" && $vehicle["Certified"] == "0") {
        $cert_mess = "DFWCertAutos";
    }
    elseif (!in_array($vehicle['make'], array('Cadillac','Honda') )) {
        $cert_mess = "DFWCertAutos";
    }
?>
<div style="font-size:10px; padding:10px; padding-top: 0px;">*This car is <?php 
echo $cert_mess ?> certified.</div>

Any suggestions? currently it just displays $cert_mess as 'make' and ignores the if / else if statements.

Probably none of your if statements execute due to bad logic? Have you even tried to debug it? — Mārtiņš Briedis
– Mārtiņš Briedis, Commented May 16, 2012 at 1:26
Actually I just figured it out - did a var_dump and "certified" was correct not "Certified". Thanks for the help! Any recommendations to make this code a little cleaner/simpler? — Jerry Virgo
– Jerry Virgo, Commented May 16, 2012 at 1:44

Ricardo Lohmann · Accepted Answer · 2012-05-16 01:48:36Z

1

A simpler code can be the following:

$cert_mess = $vehicle['make'];
if (($vehicle["make"] == "Honda" && $vehicle["Certified"] == "0")
    || ($vehicle["make"] == "Cadillac" && $vehicle["Certified"] == "0")
    || !in_array($vehicle['make'], array('Cadillac','Honda'))
) {
    $cert_mess = "DFWCertAutos";
}

answered May 16, 2012 at 1:48

Ricardo Lohmann

26.4k7 gold badges86 silver badges84 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

Okonomiyaki3000 · Accepted Answer · 2012-05-16 01:53:39Z

1

Simpler still:

$cert_mess = $vehicle['make'];
if (!in_array($vehicle['make'], array('Cadillac', 'Honda')) || $vehicle['certified'] == '0')
{
    $cert_mess = 'DFWCertAutos';
}

answered May 16, 2012 at 1:53

Okonomiyaki3000

3,70625 silver badges23 bronze badges

Collectives™ on Stack Overflow

PHP if/else statement issue

2 Answers 2

Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related