jQuery variable within a selector

Question

I need $('.mk[value=x]') to work, but it does Not while $('.mk[value=1]') does. Please someone help

<body>
<span class="mk" value="1">1</span>
<span class="mk" value="1">1</span>
<span class="mk" value="3">3</span>
<input id="update" type="button" value="1" />
</body>

<script type="text/javascript">
$('#update').click(function(){
    var x = this.value //--> x =1 
       $('.mk[value=x]').each(function(key, value) { //--> NOT WORKING !
       $('.mk[value=1]').each(function(key, value) { //--> WORKING !
       $(this).replaceWith('<span class="mk" value="2">2</span>')
       });
    })
</script>

Rory McCrossan · Accepted Answer · 2012-04-09 15:57:20Z

7

You need to append the x variable to the string:

$(".mk[value='" + x + "']").each(function(key, value)

Also, you should note that value is not a valid attribute of span, so this code will cause validation issues.

answered Apr 9, 2012 at 15:57

Rory McCrossan

338k41 gold badges321 silver badges353 bronze badges

Sign up to request clarification or add additional context in comments.

4 Comments

Matt Ball Over a year ago

+1 for (aside from being right) quoting the attribute value in the selector.

user1106925 Over a year ago

@MДΓΓБДLL: Quotes for simple attribute values are not required.

Rory McCrossan Over a year ago

@amnotiam they may not be required, but they are good practice IMO.

Ray C Lin Over a year ago

Thanks a lot for the quick answer !

Roko C. Buljan · Accepted Answer · 2012-04-09 15:57:55Z

1

Try that way:

$('.mk[value='+x+']').each(

answered Apr 9, 2012 at 15:57

Roko C. Buljan

209k41 gold badges335 silver badges346 bronze badges

Comments

Gabriele Petrioli · Accepted Answer · 2012-04-09 15:59:19Z

1

You need to either concatenate it to the string

$('.mk[value='+ x +']').each(function(key, value)

or use .filter()

$('.mk').filter(function(){return this.value === x;}).each(function(key, value)

or since you already use each on them you can do the filtering there

$('.mk').each(function(key, value) {
      if (this.value === x) {
          this.replaceWith('<span class="mk" value="2">2</span>');
      }
   });
})

answered Apr 9, 2012 at 15:59

Gabriele Petrioli

197k35 gold badges275 silver badges331 bronze badges

Comments

Romi Halasz · Accepted Answer · 2012-04-09 16:00:45Z

1

The reason why it doesn't work is that '.mk[value=x]' is a standard string and it doesn't get parsed.

Try changing the selector to '.mk[value=' + x + ']' and x will be replaced with the variable's value.

answered Apr 9, 2012 at 16:00

Romi Halasz

2,0091 gold badge14 silver badges23 bronze badges

Comments

dcap · Accepted Answer · 2012-04-09 15:57:59Z

0

change this

$('.mk[value=x]')

to

$('.mk[value='+x+']')

answered Apr 9, 2012 at 15:57

dcap

812 silver badges8 bronze badges

Comments

gideon · Accepted Answer · 2012-04-09 15:58:05Z

0

You need to put your value into the selection string like this:

$('#update').click(function(){
var x = this.value 
 $(".mk[value='" + x + "']").each(function(key, value) {
  this.replaceWith('<span class="mk" value="2">2</span>')
 });
})

answered Apr 9, 2012 at 15:58

gideon

19.5k11 gold badges74 silver badges114 bronze badges

Collectives™ on Stack Overflow

jQuery variable within a selector

6 Answers 6

4 Comments

Comments

Comments

Comments

Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

6 Answers 6

4 Comments

Comments

Comments

Comments

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related