Skip to content

Fixed SfPopup does not show up after repeated opening issue. #141

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Mar 27, 2025
Merged

Fixed SfPopup does not show up after repeated opening issue. #141

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
160ca6b
Fixed SfPopup does not show up after repeated openning issue.
Anandh-SF4665 Mar 26, 2025
fe5edac
Added Comments for Popup not opening second time issue fix.
Anandh-SF4665 Mar 26, 2025
e2f183b
Update SfPopup.cs
Anandh-SF4665 Mar 26, 2025
8da3695
Review changes
Anandh-SF4665 Mar 26, 2025
1d8f796
Update SfPopup.cs
Anandh-SF4665 Mar 26, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 8 additions & 2 deletions maui/src/Popup/SfPopup/SfPopup.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2261,8 +2261,6 @@ void ApplyOverlayBackground()
{
_popupOverlayContainer.ApplyBackgroundColor(Colors.Transparent);
}

_popupOverlayContainer.IsVisible = true;
}
}

Expand Down Expand Up @@ -3156,6 +3154,14 @@ void SetParent()
if (_popupOverlayContainer.Parent is null || _popupView.Parent is null)
{
_popupOverlayContainer.Parent = page;

// _popupOverlayContainer visibility is set to false after dismissing the popup.
// _popupOverlayContainer will be set as the parent to popupView here from DisplayPopup().
// Due to Maui 9.0.50 changes [https://github.com/dotnet/maui/pull/20154],
// the IsVisible property of _popupView is set to false when reopening with the same instance of the popup, since _popupOverlayContainer visibility will now be false.
// _popupOverlayContainer visibility is set to true in a later section, but _popupView visibility will still remain false.
// causes popup to appear blank for second time.
_popupOverlayContainer.IsVisible = true;
_popupView.Parent = _popupOverlayContainer;
}
}
Expand Down