Fix the duplicate output #750
Open
+3
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR fixes a duplicate output bug introduced in PR #747 where b_RETURN_CODE and potentially other CobolDataStorage variables were being output twice during initialization. The fix adds a continue statement to prevent fall-through execution after handling the "new program" case in the base_cache loop.
- Added
continuestatement to prevent duplicate processing when outputting CobolDataStorage variables for a new PROGRAM-ID - Added
free(base_name)and comment output before thecontinueto match the pattern used in the fall-through path - Prevents both duplicate output and a potential double-free memory bug
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#747 でCobolDataStorage型の変数の出力をするときに、base_cacheを出力するところのif文を修正したが、
b_RETURN_CODEが2回出力されてしまうようになっていたので、1回のみ出力されるように修正した。