-
Notifications
You must be signed in to change notification settings - Fork 7.8k
feat(nesso-n1): add comprehensive battery management API #12052
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
👋 Hello imliubo, we appreciate your contribution to this project! 📘 Please review the project's Contributions Guide for key guidelines on code, documentation, testing, and more. 🖊️ Please also make sure you have read and signed the Contributor License Agreement for this project. Click to see more instructions ...
Review and merge process you can expect ...
|
|
@facchinm PTAL |
406813a to
f943806
Compare
facchinm
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
f943806 to
366d26a
Compare
|
Sorry, final default parameter adjustments were made :) |
Signed-off-by: imliubo <imliubo@makingfun.xyz> Implement full NessoBattery class with: - AW32001 charger control (charge current/voltage, UVLO, watchdog, Hi-Z mode) - BQ27220 fuel gauge telemetry (voltage, current, power, temperature, cycle count) - Register enums and named constants replacing magic numbers - Datasheet references for all ICs
366d26a to
dca94e1
Compare
|
Imho, adding code which conflicts to the driver library from the manufacturer https://github.com/M5Stack/M5Unified is not the best idea. |
|
@Jason2866 AFAIK Li Bo works for M5Stack. I think this is intended. (although I agree it would be best to avoid conflicts if possible) |
Signed-off-by: imliubo imliubo@makingfun.xyz
Implement full NessoBattery class with:
Description of Change
Add comprehensive battery management API for Arduino Nesso N1 board, providing full control and monitoring capabilities for the onboard AW32001 battery charger and BQ27220 fuel gauge.
Test Scenarios
I have tested my Pull Request on Arduino-esp32 core v3.3.4 with Arduino Nesso N1(ESP32C6) board.