Skip to content

Conversation

@imliubo
Copy link

@imliubo imliubo commented Nov 21, 2025

Signed-off-by: imliubo imliubo@makingfun.xyz

Implement full NessoBattery class with:

  • AW32001 charger control (charge current/voltage, UVLO, watchdog, Hi-Z mode)
  • BQ27220 fuel gauge telemetry (voltage, current, power, temperature, cycle count)
  • Register enums and named constants replacing magic numbers
  • Datasheet references for all ICs

Description of Change

Add comprehensive battery management API for Arduino Nesso N1 board, providing full control and monitoring capabilities for the onboard AW32001 battery charger and BQ27220 fuel gauge.

Test Scenarios

I have tested my Pull Request on Arduino-esp32 core v3.3.4 with Arduino Nesso N1(ESP32C6) board.

@imliubo imliubo requested a review from P-R-O-C-H-Y as a code owner November 21, 2025 07:50
@github-actions
Copy link
Contributor

github-actions bot commented Nov 21, 2025

Messages
📖 🎉 Good Job! All checks are passing!

👋 Hello imliubo, we appreciate your contribution to this project!


📘 Please review the project's Contributions Guide for key guidelines on code, documentation, testing, and more.

🖊️ Please also make sure you have read and signed the Contributor License Agreement for this project.

Click to see more instructions ...


This automated output is generated by the PR linter DangerJS, which checks if your Pull Request meets the project's requirements and helps you fix potential issues.

DangerJS is triggered with each push event to a Pull Request and modify the contents of this comment.

Please consider the following:
- Danger mainly focuses on the PR structure and formatting and can't understand the meaning behind your code or changes.
- Danger is not a substitute for human code reviews; it's still important to request a code review from your colleagues.
- To manually retry these Danger checks, please navigate to the Actions tab and re-run last Danger workflow.

Review and merge process you can expect ...


We do welcome contributions in the form of bug reports, feature requests and pull requests.

1. An internal issue has been created for the PR, we assign it to the relevant engineer.
2. They review the PR and either approve it or ask you for changes or clarifications.
3. Once the GitHub PR is approved we do the final review, collect approvals from core owners and make sure all the automated tests are passing.
- At this point we may do some adjustments to the proposed change, or extend it by adding tests or documentation.
4. If the change is approved and passes the tests it is merged into the default branch.

Generated by 🚫 dangerJS against dca94e1

@me-no-dev
Copy link
Member

@facchinm PTAL

@imliubo imliubo force-pushed the feat(boards-nesso-n1) branch 2 times, most recently from 406813a to f943806 Compare November 21, 2025 08:40
Copy link
Contributor

@facchinm facchinm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@imliubo imliubo force-pushed the feat(boards-nesso-n1) branch from f943806 to 366d26a Compare November 21, 2025 08:53
@imliubo
Copy link
Author

imliubo commented Nov 21, 2025

Sorry, final default parameter adjustments were made :)

Signed-off-by: imliubo <imliubo@makingfun.xyz>

Implement full NessoBattery class with:
- AW32001 charger control (charge current/voltage, UVLO, watchdog, Hi-Z mode)
- BQ27220 fuel gauge telemetry (voltage, current, power, temperature, cycle count)
- Register enums and named constants replacing magic numbers
- Datasheet references for all ICs
@imliubo imliubo force-pushed the feat(boards-nesso-n1) branch from 366d26a to dca94e1 Compare November 21, 2025 09:21
@Jason2866
Copy link
Collaborator

Jason2866 commented Nov 21, 2025

Imho, adding code which conflicts to the driver library from the manufacturer https://github.com/M5Stack/M5Unified is not the best idea.
Arduino just sells this device under its name (without providing any real support)

@lucasssvaz
Copy link
Member

lucasssvaz commented Nov 21, 2025

@Jason2866 AFAIK Li Bo works for M5Stack. I think this is intended. (although I agree it would be best to avoid conflicts if possible)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants