Skip to content

Conversation

@dagood
Copy link
Member

@dagood dagood commented Oct 8, 2019

This was for:

Use "5" prefix to avoid colliding with Core-Setup builds that still produce WindowsDesktop.

Now that WindowsDesktop is removed from Core-Setup, it is no longer necessary.

The 5 can also break builds: once 10 or more builds happen, the build number becomes ".510", which is an invalid format according to Arcade, causing the build to fail.

/cc @MichaelSimons

@dagood dagood self-assigned this Oct 8, 2019
@dagood dagood merged commit 206c792 into dotnet:master Oct 8, 2019
@dagood dagood deleted the rm-5 branch October 8, 2019 15:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant