Skip to content

Fix CrossGen2 exit code handling in bash test scripts #121891

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from
+4 −0
Draft

Fix CrossGen2 exit code handling in bash test scripts #121891

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5a5b224
Initial plan
Copilot Nov 22, 2025
3c65b81
Fix: Skip R2RDump when CrossGen2 fails in bash script
Copilot Nov 22, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions src/tests/Common/CLRTest.CrossGen.targets
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -148,6 +148,10 @@ if [ ! -z ${RunCrossGen2+x} ]%3B then
$__Command
__cg2ExitCode=$?
if [ $__cg2ExitCode -ne 0 ]; then
Copy link
Member

@jkotas jkotas Nov 22, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is going to skip the code after echo "Crossgen2 compilation finished, exit code" that does not look desirable.

return
fi
echo "Running R2RDump: $__R2RDumpCommand"
$__R2RDumpCommand
__r2rDumpExitCode=$?
Expand Down