-
Notifications
You must be signed in to change notification settings - Fork 5.2k
[RyuJit/WASM] Reach the NYI in genFnProlog
#121863
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch |
df931f7 to
4f0d352
Compare
51223ba to
850a98a
Compare
|
FYI @kg -- start of some emitter work for WASM. cc @dotnet/jit-contrib |
850a98a to
95576a4
Compare
|
@dotnet/jit-contrib |
| case GT_ADD: | ||
| genCodeForBinary(treeNode->AsOp()); | ||
| break; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In the future is it possible for this sort of thing to be table-driven, by looking up the AsOp() value in a table optimistically? Or do you think we'll need a big switch?
| break; | ||
|
|
||
| case GT_IL_OFFSET: | ||
| // Do nothing; this node is a marker for debug info. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would we eventually want to do something with this node once we start generating DWARF debug info?
| GetEmitter()->emitIns_S(ins_Load(type), emitTypeSize(tree), tree->GetLclNum(), 0); | ||
| genProduceReg(tree); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would have expected to see an emit with a memarg here, am I misunderstanding what this does?
Pulling on the thread of NYIs a bit further. We now have this for my
Problem(int a, int b) => a + b;: