Enable some HotReload tests for FieldRVA. #117952
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR enables and fixes Hot Reload tests for FieldRVA functionality by uncommenting previously disabled test attributes and correcting variable references in test assertions. The changes contribute to addressing issue #114748 related to FieldRVA Hot Reload support.
Key changes:
- Uncommented test attributes to enable FieldRVA Hot Reload testing on supported runtimes
- Fixed incorrect variable references in commented assertions within the test
- Updated test implementation to return array element values instead of lengths
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| ApplyUpdateTest.cs | Enables FieldRVA test execution and fixes variable name references in assertions |
| AddFieldRVA_v1.cs | Updates test implementation to return array elements instead of lengths for Hot Reload testing |
Member
Author
|
/cc @steveisok @tmat |
Contributor
|
Tagging subscribers to this area: @steveisok, @dotnet/dotnet-diag |
Open
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contributes to #114748
This enables some of the testing. There still appears to be failures in the generated delta.