Fix duplicate parameter names in introduce parameter refactoring #81404
+158
−4
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The "Introduce parameter" refactoring generated duplicate parameter names when the inferred name conflicted with existing parameters, causing CS0100 and CS0229 compiler errors.
Changes
Modified
GetNewParameterNameAsyncinIntroduceParameterDocumentRewriter.csto useISemanticFactsService.GenerateUniqueName, ensuring generated parameter names don't conflict with existing parameters by appending numerical suffixes when neededAdded test coverage for all three code action variants (direct refactoring, trampoline, overload) and edge cases including multiple conflicts
Example
Before:
After:
// Generated: int M(int v, int v1) { }Original prompt
💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.