Combine and add expression tree restrictions #36991
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
ping @adegeo for review |
jsquire
reviewed
Sep 7, 2023
Contributes to dotnet#36356 One of the new compiler errors added for collection expressions is that collection expressions are not allowed in expression trees. There are many features in the language that can't be used in expression trees. While adding this new error create a page to handle all the expression tree restrictions.
ff0ef9e to
950a6b7
Compare
adegeo
approved these changes
Sep 7, 2023
Contributor
adegeo
left a comment
There was a problem hiding this comment.
LGTM. Some minor things to consider.
docs/csharp/language-reference/compiler-messages/expression-tree-restrictions.md
Outdated
Show resolved
Hide resolved
docs/csharp/language-reference/compiler-messages/expression-tree-restrictions.md
Outdated
Show resolved
Hide resolved
docs/csharp/language-reference/compiler-messages/expression-tree-restrictions.md
Outdated
Show resolved
Hide resolved
Co-authored-by: Andy (Steve) De George <67293991+adegeo@users.noreply.github.com>
BillWagner
commented
Sep 7, 2023
docs/csharp/language-reference/compiler-messages/expression-tree-restrictions.md
Outdated
Show resolved
Hide resolved
…ee-restrictions.md
IEvangelist
pushed a commit
to IEvangelist/docs
that referenced
this pull request
Oct 2, 2023
* Combine and add expression tree restrictions Contributes to dotnet#36356 One of the new compiler errors added for collection expressions is that collection expressions are not allowed in expression trees. There are many features in the language that can't be used in expression trees. While adding this new error create a page to handle all the expression tree restrictions. * fix typo in redirection * edit pass and proofread * run clean-repo to fix links. * grammar check. * Apply suggestions from code review Co-authored-by: Andy (Steve) De George <67293991+adegeo@users.noreply.github.com> * Update docs/csharp/language-reference/compiler-messages/expression-tree-restrictions.md --------- Co-authored-by: Andy (Steve) De George <67293991+adegeo@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contributes to #36356
Fixes #35573
One of the new compiler errors added for collection expressions is that collection expressions are not allowed in expression trees.
There are many features in the language that can't be used in expression trees. While adding this new error create a page to handle all the expression tree restrictions.
Internal previews