Skip to content

.net 6 updates to Architecting Modern Web Apps Azure eBook #27090

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 16 commits into from
Nov 30, 2021
Merged

.net 6 updates to Architecting Modern Web Apps Azure eBook #27090

merged 16 commits into from
Nov 30, 2021

Conversation

@ardalis
Copy link
Contributor

@ardalis ardalis commented Nov 15, 2021

First pass of updates to the ebook to get it ready for net6.

@dotnet-bot dotnet-bot added this to the November 2021 milestone Nov 15, 2021
@ardalis @IEvangelist
Update docs/architecture/microservices/microservice-ddd-cqrs-patterns…
62d74e6 
…/infrastructure-persistence-layer-implementation-entity-framework-core.md

Co-authored-by: David Pine <david.pine@microsoft.com>
@ardalis
Copy link
Contributor Author

ardalis commented Nov 16, 2021

Thanks @IEvangelist - I went looking for a sample of the latest "note" syntax but couldn't find one.

Good to :shipit: ?

@tdykstra
Copy link
Contributor

tdykstra commented Nov 16, 2021

I went looking for a sample of the latest "note" syntax but couldn't find one.

https://docs.microsoft.com/en-us/contribute/markdown-reference#alerts-note-tip-important-caution-warning

@IEvangelist
Copy link
Member

IEvangelist commented Nov 16, 2021

Thanks @IEvangelist - I went looking for a sample of the latest "note" syntax but couldn't find one.

Good to :shipit: ?

I'm still reviewing it... hold my coffee.

IEvangelist
IEvangelist requested changes Nov 16, 2021
View reviewed changes
Copy link
Member

@IEvangelist IEvangelist left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks of the PR @ardalis, I have some suggestions to help improve this a bit more.

docs/architecture/modern-web-apps-azure/develop-asp-net-core-mvc-apps.md

```csharp
[HttpPut("{id}")]
public async Task<IActionResult> Put(int id, [FromBody]Author author)
Copy link
Member

@IEvangelist IEvangelist Nov 16, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
public async Task<IActionResult> Put(int id, [FromBody]Author author)
public async Task<IActionResult> Put(int id, [FromBody] Author author)

@ardalis
Copy link
Contributor Author

ardalis commented Nov 17, 2021

@IEvangelist can you go ahead and commit all of your suggestions? Thanks!

@ardalis
Copy link
Contributor Author

ardalis commented Nov 17, 2021

Good to merge?

@IEvangelist
Copy link
Member

IEvangelist commented Nov 17, 2021

@IEvangelist can you go ahead and commit all of your suggestions? Thanks!

For future PRs, we ask that you commit suggestions and update your branch / PR.

Good to merge?

Hi @ardalis, we'll merge it when it's approved and finalized. Still reviewing a few bits, thank you for your patience. We'll let you know when that happens. Thanks again

nishanil
nishanil reviewed Nov 22, 2021
View reviewed changes
Copy link
Member

@nishanil nishanil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ardalis A few suggestions to consider. A few statements looked more promotional than an official recommendation. I suggest moving those to eShop's wiki (wherever appropriate).

@ardalis
Copy link
Contributor Author

ardalis commented Nov 29, 2021

Moved a lot of pattern implementation stuff to eShopOnWeb wiki which is still in progress but quickly coming together.

IEvangelist
IEvangelist approved these changes Nov 30, 2021
View reviewed changes
Copy link
Member

@IEvangelist IEvangelist left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, we'll :shipit: - thank you 🙏

@IEvangelist IEvangelist merged commit 6a833c3 into dotnet:aspnet-ebook-net6 Nov 30, 2021
IEvangelist added a commit that referenced this pull request Dec 14, 2021
@IEvangelist @ardalis @nishanil
Upgrade Architecting Modern Web Apps Azure eBook to .NET 6 (#27547)
4ae67f8 
* .net 6 updates to Architecting Modern Web Apps Azure eBook (#27090)

* update index to 6.0

* update principles

* update chapters to dotnet 6

* address issue #20187 by updating links/references

* Updates for .net 6

* fix image transparency

* Update docs/architecture/microservices/microservice-ddd-cqrs-patterns/infrastructure-persistence-layer-implementation-entity-framework-core.md

Co-authored-by: David Pine <david.pine@microsoft.com>

* respond to feedback; update formatting/indents

* Apply suggestions from code review per @ardalis

* Update docs/architecture/modern-web-apps-azure/develop-asp-net-core-mvc-apps.md

Co-authored-by: David Pine <david.pine@microsoft.com>

* Update docs/architecture/modern-web-apps-azure/develop-asp-net-core-mvc-apps.md

Co-authored-by: Nish Anil <nish@microsoft.com>

* Update docs/architecture/modern-web-apps-azure/develop-asp-net-core-mvc-apps.md

Co-authored-by: Nish Anil <nish@microsoft.com>

* update based on review

Co-authored-by: David Pine <david.pine@microsoft.com>
Co-authored-by: Nish Anil <nish@microsoft.com>

* update ms.date (#27514)

update VS screenshots

* updating last startup references (#27518)

* Update docs/architecture/modern-web-apps-azure/test-asp-net-core-mvc-apps.md

* Update docs/architecture/modern-web-apps-azure/test-asp-net-core-mvc-apps.md

Co-authored-by: Steve Smith <steve@kentsmiths.com>
Co-authored-by: Nish Anil <nish@microsoft.com>
@ardalis ardalis deleted the ardalis/modernwebapps6 branch February 2, 2022 16:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@nishanil nishanil nishanil left review comments

@IEvangelist IEvangelist IEvangelist approved these changes

@BillWagner BillWagner Awaiting requested review from BillWagner

Assignees

No one assigned

Labels

dotnet-architecture/svc dotnet-azure/svc dotnet-csharp/svc errors-warnings/subsvc lang-reference/subsvc microservices/subsvc modern-web-apps-azure/subsvc whats-new/subsvc

Projects

None yet

Milestone

November 2021

Development

Successfully merging this pull request may close these issues.

5 participants

@ardalis @tdykstra @IEvangelist @nishanil @dotnet-bot