Skip to content

Conversation

@Shawn1874
Copy link

Title

Add a correct example for the ReDim statement

Summary

The previous example contained no use of the ReDim statement as the preceding paragraph implied. It was an example of a List collection type. This is an article about arrays, not Lists.

Fixes #Issue_Number

N/A

Details

Summary should be sufficient.

Suggested Reviewers

If you know who should review this, use '@' to request a review.

The previous example contained no use of the ReDim statement as the preceding paragraph implied.  It was an example of a List collection type.
@dnfclas
Copy link

dnfclas commented Jun 30, 2017

This seems like a small (but important) contribution, so no Contribution License Agreement is required at this point. We will now review your pull request.
Thanks,
.NET Foundation Pull Request Bot

@svick
Copy link
Contributor

svick commented Jun 30, 2017

The code in Arrays in Visual Basic, section Creating an Array is definitely wrong, but I don't think this is the way to fix it, because that would break the article that uses this snippet correctly: Collection Initializers (Visual Basic).

I'll look at this further and if I find something, I'll continue in the issue you created about this (#2526).

@Shawn1874
Copy link
Author

That sounds fair. Go ahead and fix the article under #2526. This is my first attempt at contributing and I didn't realize how the snippets were setup. Perhaps it would be better if someone more experienced fixes it until I learn more about how the snippets are linked into articles. I appreciate the quickness with which the issue was reviewed.

@svick svick mentioned this pull request Jun 30, 2017
@mairaw
Copy link
Contributor

mairaw commented Jul 1, 2017

Thank you @Shawn1874 and @svick for looking into this. I'm closing this one and commenting on the new PR #2526.

@mairaw mairaw closed this Jul 1, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants