Skip to content

fix vPrint crashes on platforms where vsnprintf invalidates va_list #40

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 8, 2024
Merged

fix vPrint crashes on platforms where vsnprintf invalidates va_list #40

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion src/Arduino_DebugUtils.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -130,6 +130,10 @@ void Arduino_DebugUtils::print(int const debug_level, const __FlashStringHelper
******************************************************************************/

void Arduino_DebugUtils::vPrint(char const * fmt, va_list args) {

va_list args_copy;
va_copy(args_copy, args);

// calculate required buffer length
int msg_buf_size = vsnprintf(nullptr, 0, fmt, args) + 1; // add one for null terminator
#if __STDC_NO_VLA__ == 1
Expand All @@ -139,7 +143,8 @@ void Arduino_DebugUtils::vPrint(char const * fmt, va_list args) {
char msg_buf[msg_buf_size];
#endif

vsnprintf(msg_buf, msg_buf_size, fmt, args);
vsnprintf(msg_buf, msg_buf_size, fmt, args_copy);
va_end(args_copy);

if (_newline_on) {
_debug_output_stream->println(msg_buf);
Expand Down