curl POST inside a for loop

Question

the following works for create a single user:

curl -X POST  --anyauth -u admin:admin --header "Content-Type:application/json" \
  -d '{"user-name":"joe",
       "password": "cool",
       "role": [ "rest-reader", "rest-writer" ]
      }' \
  http://localhost:8002/manage/v2/users

but it failed when inside a for loop to create multiple users (one at a time)

for i in john frank bob
do
  curl -X POST  --anyauth -u admin:admin --header "Content-Type:application/json" \
  -d '{"user-name":"$i",
       "password": "$i",
       "role": [ "rest-reader", "rest-writer" ]
      }' \
  http://localhost:8002/manage/v2/users
done

where did i do wrong?

How do you know it's failing? Error code, message, ... Could you add that to the question? — Eduardo Trápani
– Eduardo Trápani, Commented Jun 14, 2020 at 17:41

Freddy · Accepted Answer · 2020-06-14 17:46:16Z

7

Your data string is enclosed in single quotes, but variables are not expanded within single quotes.
You may close the opening single quote with a ', add the double quoted variable with "$i" and open the single quoted string again with ':

for i in john frank bob
do
  curl -X POST  --anyauth -u admin:admin --header "Content-Type:application/json" \
  -d '{"user-name":"'"$i"'",
       "password": "'"$i"'",
       "role": [ "rest-reader", "rest-writer" ]
      }' \
  http://localhost:8002/manage/v2/users
done

answered Jun 14, 2020 at 17:46

Freddy

26.3k1 gold badge27 silver badges64 bronze badges

Thank you for the explanation, greatly appreciated!

CJ Chang
– CJ Chang

2020-06-14 18:44:04 +00:00
Commented Jun 14, 2020 at 18:44

Add a comment |

Sandeep Kothari · Accepted Answer · 2020-06-14 17:45:24Z

5

try removing quotes around $i

so, basically :

'{"username":"'$i'"}' try this:

for i in john frank bob
do
  curl -X POST  --anyauth -u admin:admin --header "Content-Type:application/json" \
  -d '{"user-name":"'$i'",
       "password": "'$i'",
       "role": [ "rest-reader", "rest-writer" ]
      }' \
  http://localhost:8002/manage/v2/users
done

answered Jun 14, 2020 at 17:45

Sandeep Kothari

4372 silver badges6 bronze badges

Add a comment |

Stack Exchange Network

curl POST inside a for loop

2 Answers 2

You must log in to answer this question.

Hot Network Questions

curl POST inside a for loop

2 Answers 2

You must log in to answer this question.

Related

Hot Network Questions