0

This is a weird one - it should work.

I have this file /home/foo/waldo.sh

#!/usr/bin/env bash

waldo(){

   if [[ -z $(command -v waldo) ]]; then
       npm install -g '@oresoftware/waldo' || {
         return 1;
      }
   fi

   command waldo "$@"
}


export -f waldo;

if I source the file with:

. "/home/foo/waldo.sh";

and then run

waldo

I get:

No command 'waldo' found, did you mean:
 Command 'aldo' from package 'aldo' (universe)
waldo: command not found

when I run $(which waldo), it's empty, nothing there.

however, when I run type waldo, I get:

waldo is a function
waldo () 
{ 
    if [[ -z $(command -v waldo) ]]; then
        npm install -g '@oresoftware/waldo' || { 
            return 1
        };
    fi;
    command waldo "$@"
}

anyone know why it's not being sourced or whatever?

Improve this question
6
  • 1
    You're using command substitution too much. There's no need for $(command ...) or $(which ...). Use the exit status of the command you're calling instead of checking for output. E.G.: if ! command -v waldo >/dev/null; then ... Commented Jun 23, 2018 at 22:57
  • 1
    I prefer type -a to which Commented Jun 24, 2018 at 0:56
  • @glennjackman ah yes I forgot about type -a, why is it better than which tho? Commented Jun 24, 2018 at 5:35
  • In this case, I need a command that looks up to see what's in the PATH only, ignoring shell functions, that should be somewhat obvious from the question right. Commented Jun 24, 2018 at 5:36
  • I think type -f is what I am looking for, since that suppresses bash function results Commented Jun 24, 2018 at 5:40

1 Answer 1

Reset to default
3

The function is found and executed but it contains

command waldo

That's what the error message refers to.

You could handle this problem in the function:

if hash waldo >/dev/null 2>&1; then
    command waldo "$@"
else
    echo 'ERROR: ...'
fi
Improve this answer
5
  • ok thanks! then why did the if condition evaluate to false then? in other words, why didn't command -v waldo evaluate to empty string? Commented Jun 23, 2018 at 22:09
  • I see the update that should help, but I think in the if check to see if it's installed already, I need to use something other than command -v waldo ? Commented Jun 23, 2018 at 22:11
  • maybe which waldo instead? Commented Jun 23, 2018 at 22:11
  • @AlexanderMills Is the npm install executed (set -x)? Does it put a binary waldo in the PATH? Commented Jun 23, 2018 at 22:26
  • yeah it does put "waldo" in the $PATH Commented Jun 23, 2018 at 22:53

You must log in to answer this question.

Start asking to get answers

Find the answer to your question by asking.

Ask question

Explore related questions

See similar questions with these tags.