PHP script for upload

Question

I have written a script in PHP which is supposed to enable yuo to upload files. However, it can't seem to move the file to the right folder after it has uploaded it. Can anyone see what the problem is?

Here is the code:

    

    echo 'This is upload.php';
    $target_path = 'wwwroot/rsfleet.co.uk/ipad_test/sub/';
    echo 'Size of file: ';
    echo $_FILES['userfile']['size'];
    $target_path = $target_path . basename($_FILES['userfile']['name']);
    echo $target_path; 
    if (is_uploaded_file($_FILES['userfile']['tmp_name'])) {
        echo 'File uploaded OK.';
    } else {
        echo 'Problem with file upload.';
    }
    if (move_uploaded_file(basename($_FILES['userfile']['tmp_name']), $target_path)) {
        echo 'The file ' . basename($_FILES['userfile']['name']) . ' has been moved';
    } 
    else 
    {
        echo 'Error moving file. Please try again.';
    }
    echo 'End of page.';

Have you looked in your server log to see if there are any error messages? — Ian
– Ian, Commented Oct 4, 2011 at 14:22
Have you checked the server/PHP logs? Does the server/PHP process have write permissions on the directory you're trying to move the uploaded file to? — Alex
– Alex, Commented Oct 4, 2011 at 14:23

ThiefMaster · Accepted Answer · 2011-10-04 14:25:35Z

2

move_uploaded_file(basename($_FILES['userfile']['tmp_name']), ...)

This cannot work. It would only work if the temporary file was stored in the working directory (protip: it's not). Use the following instead:

move_uploaded_file($_FILES['userfile']['tmp_name'], ...)

answered Oct 4, 2011 at 14:25

ThiefMaster

320k85 gold badges608 silver badges648 bronze badges

Sign up to request clarification or add additional context in comments.

2 Comments

user947185 Over a year ago

Thanks for your help. By the way, how can I look in the server log? It is a Windows server.

Marc B Over a year ago

As well, $target_path is probably wrong too. Looks like you're trying to do an absolute path, but forgot the leading /.

genesis · Accepted Answer · 2011-10-04 14:26:47Z

0

Change

(move_uploaded_file(($_FILES['userfile']['tmp_name']),

to

(move_uploaded_file(($_FILES['userfile']['tmp_name']),

and it'll probably work

because $_FILES['userfile']['tmp_name'] has already full path

answered Oct 4, 2011 at 14:26

genesis

51.1k20 gold badges99 silver badges127 bronze badges

4 Comments

user947185 Over a year ago

Thanks for your help, everyone. Sadly, it's still not working. Sometimes, I get error 500. Does anyone know how I can view the server log?

genesis Over a year ago

@user947185: /var/log/apache2/apache2.log

genesis Over a year ago

@user947185: btw targetpath should start with /

user947185 Over a year ago

I have managed to find the log file. It contains entries like this one: 2011-10-04 14:09:23 POST /ipad_test/upload.php 82.36.128.237 HTTP/1.1 Mozilla/5.0+(Windows;+U;+Windows+NT+6.1;+en-GB;+rv:1.9.2.8)+Gecko/20100722+Firefox/3.6.8 rsfleet.co.uk/ipad_test/upload.html www.rsfleet.co.uk 200 0 365 Does this shed any light on the problem?

Luke · Accepted Answer · 2011-10-04 14:28:22Z

0

Check that the folder has the correct permissions, these are called a CHMOD command.

In FTP programs like Filezilla, you can set these permission by right mouse clicking on the folder and clicking 'File Permissions...'

answered Oct 4, 2011 at 14:28

Luke

23.8k31 gold badges121 silver badges202 bronze badges

Comments

jancha · Accepted Answer · 2011-10-04 14:33:22Z

0

I suppose problem is here:

$target_path = 'wwwroot/rsfleet.co.uk/ipad_test/sub/';

change to

$target_path = '/wwwroot/rsfleet.co.uk/ipad_test/sub/';

but it's just assumption.

also, basename is not necessary when moving files.

answered Oct 4, 2011 at 14:33

jancha

4,9851 gold badge27 silver badges40 bronze badges

Collectives™ on Stack Overflow

PHP script for upload

4 Answers 4

2 Comments

4 Comments

Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

4 Answers 4

2 Comments

4 Comments

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related