How do I replace an array element within an if statement? C#

Question

This is the second version of this code I've gone through as the first version ran too quickly for the Random function to work properly. I'm trying to make sure none of the randomly generated numbers are the same and if they are replace them in the array but it's not letting me call the array. Can someone tell me what I'm doing wrong?

using System;
using System.Timers;
using System.Collections.Generic;
using System.Linq;
using System.Text;
using System.Threading.Tasks;

namespace ConsoleApp4
{
    class Program
    {
        public static Timer aTimer;

        static void Main(string[] args)
        {
            //Create three different random integers and store them
            Random rnd = new Random();
            int RandA = rnd.Next(0, 26);
            int RandB = rnd.Next(0, 26);
            int RandC = rnd.Next(0, 26);

            //Turn those three variables into an array
            int[] RandArray = { RandA, RandB, RandC };

            //Make sure there are no duplicates
            if (RandArray[0] == RandArray[1])
            {
                int RandArray[0] = rnd.Next(0, 26);
            }
            if (RandArray[1] == RandArray[2])
            {
                int RandArray[1] = rnd.Next(0, 26);
            }
            if (RandArray[2] == RandArray[0])
            {
                int RandArray[2] = rnd.Next(0, 26);
            }

            //Print out all three values seperately
            for (int i = 0; i < 3; i++)
            {
                Console.WriteLine("Value of: {1}", i, RandArray[i]);
                continue;
            }
            Console.ReadKey();
        }
    }
}

Greg · Accepted Answer · 2018-04-14 03:33:58Z

Well, I would potentially alter your approach.

public static class Randomizer
{
     private static const generator = new Random();

     public static int Generate(int minimum, int maximum) => generator.Next(minimum, maximum);
}

Then I would do the following:

public static class BuildRandom
{
     public IEnumerable<int> FillCollection(int capacity)
     {
          for(int index = 0; index < capacity; index++)
               yield return Randomizer.Generate(0, 26);
     }

     public static int GetRandomNumber() => Randomizer.Generate(0, 26);
}

Then I would simply do the following.

// Build Collection
var randomized = BuildRandom.FillCollection(5);

// Remove Duplicates
var filter = randomized.Distinct();

while(filter.Count != randomized.Count)
{
     var value = BuildRandom.GetRandomNumber();
     if(!filter.Any(number => number == value))
          filter.Concat(new { value });
}

glenebob · Accepted Answer · 2018-04-14 03:22:59Z

0

int RandArray[0] = is a syntax error. Try RandArray[0] =

answered Apr 14, 2018 at 3:22

glenebob

1,99311 silver badges11 bronze badges

1 Comment

Nesox Over a year ago

Yea that was it. Mind explaining how that was a syntax error though?

Collectives™ on Stack Overflow

How do I replace an array element within an if statement? C#

2 Answers 2

Comments

1 Comment

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

Comments

1 Comment

Your Answer

Sign up or log in

Post as a guest

Related