Replace instance of item in array?

Question

I have an array with strings if the string is foo I wish to replace it with bar.

I could do a for-loop:

for (var i = carpeDiem.length - 1; i >= 0; i--) {
    if(carpeDiem[i] === '\n'){
        carpeDiem[i] = '<br \>'
    }
};

But is there a nicer way to do it. I only need to support modern browsers.

@Andreas To futher my skills and to make the code more readable for other developers. (and my future self) — Himmators
– Himmators, Commented Jul 29, 2015 at 8:12
"...make the code more readable..." After reading it the first time I know exactly what the code is going to do. Fewer lines of code doesn't always mean better readability :) If you really want to change it, you could use .forEach() or, if you don't want to modify carpeDiem, .map() — Andreas
– Andreas, Commented Jul 29, 2015 at 8:19

Fabrizio Calderan · Accepted Answer · 2015-07-29 09:16:12Z

2

You could use Array.map(), e.g. http://codepen.io/anon/pen/QbJqeq

var carpeDiem = ['\n', '<br />', '\n', '<br />'];

carpeDiem = carpeDiem.map(function(i) { 
    return i.replace('\n', '<br />') 
});

console.log(carpeDiem) // ['<br />', '<br />', '<br />', '<br />'];

edited Jul 29, 2015 at 9:16

answered Jul 29, 2015 at 8:22

Fabrizio Calderan

124k26 gold badges171 silver badges183 bronze badges

Sign up to request clarification or add additional context in comments.

1 Comment

Vidul Over a year ago

why not just carpeDiem.map(function(i) { return i.replace('\n', '<br />'); });?

Zibellino · Accepted Answer · 2015-07-29 08:17:24Z

1

https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Array/find

This is the thing for you, it's ES6 so should work at least in FF, but there are polyfills for it (that are probably doing the same as your code above).

answered Jul 29, 2015 at 8:17

Zibellino

1,4156 gold badges26 silver badges35 bronze badges

2 Comments

Andreas Over a year ago

"The find() method returns a value in the array, if an element in the array satisfies the provided testing function." How is this supposed to satisfy the requirement - replace all strings "x" with string "y"?

Andreas Over a year ago

So you're going to misuse .find() to replace the string passed as parameter s with "bar" if it matches "foo". This won't change the array! And even if it would change the value in the array it will only change the first occurance.

Collectives™ on Stack Overflow

Replace instance of item in array?

2 Answers 2

1 Comment

2 Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

1 Comment

2 Comments

Your Answer

Sign up or log in

Post as a guest

Related