How to pick a random string from string array only once

Question

I'm trying to make Hangman in C#, and in the beginning of a game you will need a word to guess, and so the game wont be boring you can get many words (only one at a time). But when you start a new game you wont get a word you've already guessed. So i have to choose a random string that i havent chosen already.

I've tried multiple methods to solve this, but none have succeded.

Method #1:

Here I run the NewWord-function, and then add 1 to numberOfTries.

string[] wordArr = { "PROGRAMMERING", "CSHARP", "STOL", "ELEV", "VISUAL", "STUDIO" };
int numberOfTries = 0;
int randomNumber = -1;


protected string NewWord()
{
    if (!(numberOfTries >= wordArr.Length))
    {
        randomNumber = RandomNumberFromTo(0, (wordArr.Length - numberOfTries));

        ChangeWord(((wordArr.Length - numberOfTries)-1), randomNumber);

        return wordArr[(randomNumberl)];
    }
    else
    {
        return "There are no more new words!! :(";
    }
}


private int RandomNumberFromTo(int NumberA, int NumberB)
{
    System.Threading.Thread.Sleep(2);
    Random minRandomGenerator = new Random();
    System.Threading.Thread.Sleep(3);
    return minRandomGenerator.Next(NumberA, NumberB);
}



protected void ChangeWord (int NumberA, int NumberB)
{
    string cashe1 = wordArr[NumberA];
    wordArr[NumberA] = wordArr[NumberB];
    wordArr[NumberB] = cashe1;
    return;
}

Method #2 I've found here on StackOverflow but it didn't work.

Here I also run the NewWord-function, and then add 1 to numberOfTries.

string[] wordArr = { "PROGRAMMERING", "CSHARP", "STOL", "ELEV", "VISUAL", "STUDIO" };       
int numberOfTries = 0;
Random random = new Random();
protected string NyttOrd()
{
    if (!(numberOfTries >= wordArr.Length))
    {
        var names = new List<string> { "PROGRAMMERING", "CSHARP", "STOL", "ELEV", "VISUAL", "STUDIO" };

        System.Threading.Thread.Sleep(3);
        int index = random.Next(names.Count);
        var name = names[index];
        names.RemoveAt(index);
        return name;
    }
    else
    {
        return "There are no more new words!! :(";
    }
}

I have also tried a version where I had two different arrays, one an Int-Array and the second a String-Array. It was really messy and did not work.

I am also very new to C# i only know of the basics, like +-/*, convert, functions, and arrays.

Hard to follow the differences in your methods, but don't declare the Random class in a method. Just use a single instance throughout your code. — L.B
– L.B, Commented Mar 1, 2014 at 23:13
Pierre-Luc, he is asking for the same method, but for Int not string. L.B. Sorry for the messy code... Wil move the random class :) — Acnik
– Acnik, Commented Mar 1, 2014 at 23:21
I have edited your title. Please see, "Should questions include “tags” in their titles?", where the consensus is "no, they should not". — John Saunders
– John Saunders, Commented Mar 1, 2014 at 23:31

M.A. Hanin · Accepted Answer · 2014-03-01 23:15:48Z

2

Conceptually, you either keep track of strings you already used, or you remove strings from the list of optional strings as you use them.

To implement the first method, you can keep a hashtable of strings you've already used, and when pulling a new string - see if it is present in the hashtable (and if so, pick another one, until a "fresh" string is picked).

To implement the second method, just remove the strings you picked from the list as you pick them.

answered Mar 1, 2014 at 23:15

M.A. Hanin

8,10435 silver badges51 bronze badges

Sign up to request clarification or add additional context in comments.

1 Comment

Acnik Over a year ago

In the second method, the strings that have been chosen gets removed with: "names.RemoveAt(index);". But when i run this multiple times i still get duplicates...

spender · Accepted Answer · 2014-03-01 23:29:41Z

2

If you shuffle your word array:

var r = new Random();
var shuffledWords = wordArr.OrderBy(_ => r.Next());

then push your words into a Stack:

var wordStack = new Stack<string>(shuffledWords);

now you have a structure that will hand you random word from the collection while simultaneously removing it from the collection by using the Pop method of Stack<T> (considerably more efficiently than removing items from the front/middle of a List<T>, although your collection is so small, it hardly matters).

var someWord = wordStack.Pop();

edited Mar 1, 2014 at 23:29

answered Mar 1, 2014 at 23:20

spender

121k36 gold badges245 silver badges369 bronze badges

Comments

Tolgahan Albayrak · Accepted Answer · 2014-03-01 23:27:27Z

0

static readonly List<string> Words = new List<string>(wordArr);
static readonly Random Rnd = new Random();

public string Next()
{
    if(Words.Count < 1)
        return "There are no more new words!! :(";

    var index = Rnd.Next(0, Words.Length);
    var result = Words[index];
    Words.RemoveAt(index);

    return result;
}

edited Mar 1, 2014 at 23:27

answered Mar 1, 2014 at 23:12

Tolgahan Albayrak

3,2161 gold badge27 silver badges28 bronze badges

6 Comments

Enigmativity Over a year ago

Random.Next has odd semantics. The second parameter is one higher than the upper bound you need. So your call should be Rnd.Next(0, Words.Length) without the ` - 1`.

Enigmativity Over a year ago

Also, how does this code keep track of what words have already been used?

Tolgahan Albayrak Over a year ago

Not keeping used words, removing used words from collection, if you need to know used words then wordArr.Except(Words) will be enough.

Acnik Over a year ago

I dont need to keep track of what words I've already used when all the used words are deleted. I can keep track of how many tries I've used with a simple Int Counter :)

Enigmativity Over a year ago

@TolgahanAlbayrak - My apologies - I missed the RemoveAt in your code. I think I need to get some more sleep. :-)

|

Mr Wednesday · Accepted Answer · 2014-03-01 23:17:25Z

0

Use KeyValuePair.

The key will be your word, the value will be how many times it's been used, then just take the least used word and increment its counter.

List<KeyValuePair<string, int>>

answered Mar 1, 2014 at 23:17

Mr Wednesday

5524 silver badges18 bronze badges

2 Comments

EthanB Over a year ago

... aka Dictionary<string, int>?

Mr Wednesday Over a year ago

Yeah, same thing. :P I only used List because that's what he was already working with.

Enigmativity · Accepted Answer · 2014-03-01 23:23:34Z

0

You should represent your WordArr as a list. It's easier to work with to suit your needs.

Here's an easy way to randomize your list:

List<string> wordArr = new List<string>()
{
    "PROGRAMMERING", "CSHARP", "STOL", "ELEV", "VISUAL", "STUDIO"
};
Random random = new Random();
wordArr = wordArr.OrderBy(x => random.Next()).ToList();

Then just always take the first word in the list so that you can simply remove each word that you use like this:

wordArr.RemoveAt(0);

When the wordArr is empty then you are done.

answered Mar 1, 2014 at 23:23

Enigmativity

117k12 gold badges101 silver badges184 bronze badges

Comments

ProgrammingLlama · Accepted Answer · 2014-03-01 23:28:31Z

Since you've said you're new to programming, I'll explain the key line quickly:

.Except() compares your array to the other array and returns only unique elements. .OrderBy(x => rn.Next()) will return the array in a random order. .FirstOrDefault() will get the first entry from the array or, if the array is empty, return null.

public void GenerateWord()
{
    Random rn = new Random();
    string[] attemptedWords = LoadUsedWords();
    string[] wordArr = { "PROGRAMMERING", "CSHARP", "STOL", "ELEV", "VISUAL", "STUDIO" };
    string word = wordArr.Except(attemptedWords).OrderBy(x => rn.Next()).FirstOrDefault();
    if (string.IsNullOrEmpty(word))
    {
        Console.WriteLine("Oh no");
    }
    else
    {
        Console.WriteLine(word);
    }
}

public string[] LoadUsedWords()
{
    return new string[] { "PROGRAMMERING", "CSHARP", "STOL", "ELEV", "VISUAL" };
}

Collectives™ on Stack Overflow

How to pick a random string from string array only once

6 Answers 6

1 Comment

Comments

6 Comments

2 Comments

Comments

Comments

Your Answer

Linked

Hot Network Questions

Collectives™ on Stack Overflow

6 Answers 6

1 Comment

Comments

6 Comments

2 Comments

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Linked

Related