MYSQL printing a database record array

Question

function CHECKPENDINGORDERS($con, $oc, $pos){
    if(is_resource($con)){
        $sql = "SELECT * FROM eats_orders WHERE school_code = '$oc' AND order_status = '$pos'";
        $sqlresult = mysql_query($sql);
        #$pendingorderrow = mysql_fetch_array($sqlresult);
        while($row = mysql_fetch_assoc($sqlresult)){
            $a[] = $row;
            return $a;
        }

    }
}


$checkpendingorders =  CHECKPENDINGORDERS(MYSQL_LINK, $ordercode, $pendingorderstatus);

print_r($checkpendingorders);

I have the function above me to retrieve db records to and print it out by calling the function. But it is only printing 1 recording but I have multiple records with same ordercode and pendingorderstatus.

Shankar Narayana Damodaran · Accepted Answer · 2014-02-19 03:16:57Z

2

You need to return your `$a` at the end

<?php
function CHECKPENDINGORDERS($con, $oc, $pos){
    if(is_resource($con)){
        $sql = "SELECT * FROM eats_orders WHERE school_code = '$oc' AND order_status = '$pos'";
        $sqlresult = mysql_query($sql);
        #$pendingorderrow = mysql_fetch_array($sqlresult);
        while($row = mysql_fetch_assoc($sqlresult)){
            $a[] = $row;
            //return $a; //<---- Not here
        }

    }
    return $a; //<----- Here
}

That is because... You are getting a single row is since you are returning the $a in the first iteration itself.

edited Feb 19, 2014 at 3:16

answered Feb 19, 2014 at 3:09

Shankar Narayana Damodaran

68.6k43 gold badges102 silver badges129 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

John Conde · Accepted Answer · 2014-02-19 03:16:53Z

You need to move your return statement outside of your loop. Once that return statement is reached your function call ends thus terminating your loop.

    while($row = mysql_fetch_assoc($sqlresult)){
        $a[] = $row;
    }
    return $a;

To further improve upon your function, your function will throw a E_NOTICE error because you are not defining $a before using it. To solve this just define $a to be an empty string at the top of your function. You can also move the return statement to the end of the array so your function always returns an array, even if it is empty.

function CHECKPENDINGORDERS($con, $oc, $pos){
    $a = array();
    if(is_resource($con)){
        $sql = "SELECT * FROM eats_orders WHERE school_code = '$oc' AND order_status = '$pos'";
        $sqlresult = mysql_query($sql);
        #$pendingorderrow = mysql_fetch_array($sqlresult);
        while($row = mysql_fetch_assoc($sqlresult)){
            $a[] = $row;
        }
    }
    return $a;
}

Collectives™ on Stack Overflow

MYSQL printing a database record array

2 Answers 2

You need to return your `$a` at the end

Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

You need to return your $a at the end

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related

You need to return your `$a` at the end