Error in simple linked list code

Question

I try to create a simple linked list out of a integer vector. Why is this not working? The errors I get are:

'=' : incompatible types - from 'talstrul *' to 'node *'
'=' : cannot convert from 'talstrul*' to talstrul'

This is the .h file:

#include <stdio.h>
#include <stdlib.h>

typedef struct
{
    int num;
    struct node *next;


} talstrul;

This is the .c file:

#include <stdio.h>
#include <stdlib.h>
#include <string.h>
#include "clabb2head.h"

int main()
{   int vek[5] = {1,2,3,4,5};

    int langd = sizeof(vek)/sizeof(vek[0]);

    printf("%d",langd);

    talstrul *temp = malloc(sizeof(talstrul));
    talstrul *pek1 = NULL;
    int i;
    for(i=0; i<langd; i++)
    {

    pek1 -> num = vek[i];
    pek1 -> next = *temp;   
    *temp = pek1;
    }
}

1) Where is struct node defined? 2) Why do you expect to be able to assign *temp of type talstrul to pek1->next of type struct node*? There are more, but let's start there. — jerry
– jerry, Commented Feb 13, 2014 at 3:18
You need to change typedef struct { to typedef struct node {. There are other errors, as folks are pointing out. — Crowman
– Crowman, Commented Feb 13, 2014 at 4:30

Eric J. · Accepted Answer · 2014-02-13 03:16:16Z

4

temp is of type talstrul *

talstrul *temp = malloc(sizeof(talstrul));

You are trying to assign to next, which is of type node *

struct node *next;

Further

pek1 -> next = *temp;

dereferences temp, yielding a talstrul. You should not dereference the pointer.

The compiler is giving you a pretty good explanation of what is going wrong.

answered Feb 13, 2014 at 3:16

Eric J.

151k65 gold badges353 silver badges563 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

Soumen · Accepted Answer · 2014-02-13 04:25:14Z

0

Another problem with the code :

pek1 is assigned to NULL. Yet you try to assign pek1->num and pek1->next. You should do memory allocation for pek1 first.

answered Feb 13, 2014 at 4:25

Soumen

1,0881 gold badge13 silver badges19 bronze badges

Comments

BLUEPIXY · Accepted Answer · 2014-02-13 11:12:04Z

0

typedef struct node {
    int num;
    struct node *next;
} talstrul;
...
int vek[5] = {1,2,3,4,5};

int langd = sizeof(vek)/sizeof(vek[0]);

talstrul *pek1 = NULL;
int i;
for(i=0; i<langd; i++){
    talstrul *temp = malloc(sizeof(talstrul));

    temp -> num = vek[i];
    temp -> next = pek1;   
    pek1 = temp;
}

answered Feb 13, 2014 at 11:12

BLUEPIXY

40.2k7 gold badges37 silver badges73 bronze badges

Collectives™ on Stack Overflow

Error in simple linked list code

3 Answers 3

Comments

Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

3 Answers 3

Comments

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related