Database connection using php class and methods

Question

Here is mycode dbclass.php i am new for oops concept,

<?php
   class Database {
      private $link;
      private $hostname, $username, $password, $dbname;
      public function __construct( $hostname, $username, $password, $dbname ) {
         $this->link=mysql_connect($this->hostname,$this->username,$this->password) or die("Mysql Connection error!!");
         mysql_select_db($this->dbname,$this->link) or die("error:".mysql_error());
         return true;
      }
      public function query( $query ) {
         $result = mysql_query( $query );
         if ( !$result ) {
            die('Invalid query: ' . mysql_error());
         }
         return $result;
      }
      public function __destruct() {            
        mysql_close($this->link) or die("Error:".mysql_error());
      }
   }    
?>
<?php 
   include("dbclass.php");
   $db = new Database("localhost", "root", "password", "test");
   $result = $db->query("select * from messages");
   while ( $row = mysql_fetch_array( $result ) ) {
      echo $row['id'];
   }
?>

if i run this code it showing database not connected. I don't know why?

or mysqli_ methods (easier to understand as beginner it's allmost the same as the mysql) — Sander Visser
– Sander Visser, Commented Oct 10, 2013 at 8:56
No password was not empty im sure about that, its a correct password — user2866194
– user2866194, Commented Oct 10, 2013 at 8:59
Agree with @DaveJust, or at least use mysqli it will be easy for you to migrate. — Rolice
– Rolice, Commented Oct 10, 2013 at 9:02

chandresh_cool · Accepted Answer · 2013-10-10 08:57:25Z

2

The problem is here :

$this->link=mysql_connect($this->hostname,$this->username,$this->password)

You are not assigning the argument in function to your variables of class. Hence do this

$this->hostname = $hostname;
$this->username = $username;
$this->password = $password;

and then give:

 $this->link=mysql_connect($this->hostname,$this->username,$this->password);

answered Oct 10, 2013 at 8:57

chandresh_cool

11.9k3 gold badges32 silver badges46 bronze badges

Sign up to request clarification or add additional context in comments.

Collectives™ on Stack Overflow

Database connection using php class and methods

1 Answer 1

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

Comments

Your Answer

Sign up or log in

Post as a guest

Related