PHP: Insert array into an array

Question

Im trying to create a single array with 100 items. First for-loop runs 10 times, and for each run it runs another for-loop who inserts 10 items into the array.

But the result is only the last 10 items:

class Feed {

public $url;
public $title;

}

function feeds_array() {

for ($x = 0; $x <= 10; $x++) {
    $feeds = feed($x);
}
return $feeds;
}

function feed($x) {
for ($i = 1; $i <= 10; $i++) {
    $feed = new Feed();
    $feed->url = "u" . $x;
    $feed->title = "t" . $i;
    $feeds[] = $feed;
}
return $feeds;
}


$feeds = feeds_array();

foreach ($feeds as $feed) {
echo 'This feed is a ' . $feed->url . ' ' . $feed->title;
echo "<br>";
}

Brad Christie · Accepted Answer · 2013-09-06 16:45:28Z

2

$feeds[] = feed($x);

You're re-assigning $feeds not inserting in to it.

BTW, you should declare $feeds before you use it:

function feeds_array(){
  $feeds = array();
  for ($x = 0; $x < 10; $x++){
    $feeds[] = feed($x);
  }
  return $feeds;
}

And, as a re-write that, you actually iterate 11 times ($x <= 10). I think you just want $x < 10 (given you start at a 0 index).

Working Code:

// original feed object
class Feed
{
    public $url;
    public $title;
}

// root method to create an array of arrays
function feeds_array(){
    // create a variable we're going to be assigning to
    $feeds = array();
    // iterate ten times
    for ($x = 0; $x < 10; $x++){
            // merge/combine the array we're generating with feed() in to
            // our current `$feed` array.
        $feeds = array_merge($feeds, feed($x));
    }
    // return result
    return $feeds;
}

// nested function to create and return an array
function feed($x){
    // again, initialize our resulting variable
    $feeds = array();
    // iterate over it 10 times
    for ($y = 0; $y < 10; $y++){
            // create the new object
        $feed = new Feed();
        $feed->url = 'u' . $x;
        $feed->title = 't' . $y;
            // push it in to the result
        $feeds[] = $feed;
    }
    // return the result
    return $feeds;
}

// entry point
$feeds = feeds_array();
var_dump($feeds);

edited Sep 6, 2013 at 16:45

answered Sep 6, 2013 at 16:12

Brad Christie

102k16 gold badges160 silver badges200 bronze badges

Sign up to request clarification or add additional context in comments.

6 Comments

Dennis Sødal Christensen Over a year ago

Now i get Trying to get property of non-object in "echo 'This feed is a ' . $feed->url . ' ' . $feed->title;" By the way the results should be an array of 100 items (feed), not an array of 10 x 10 items

Brad Christie Over a year ago

@DennisSødalChristensen: See the update. You need to initialize $feeds in feed() as well.

Dennis Sødal Christensen Over a year ago

:) Thanks for your help, its very close to what im trying. Do i read it correct when i say your code makes 10 x 10 arrays? Trying to get 1 array with 100 itmes.

Brad Christie Over a year ago

Ahh, that's a bit different. Okay, then you need to use array_merge... (see updated code, esp within feeds_array)

Dennis Sødal Christensen Over a year ago

Thank you it works... now im going to sit down and understand the code (hate using code i dont understand).

|

Collectives™ on Stack Overflow

PHP: Insert array into an array

1 Answer 1

6 Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

6 Comments

Your Answer

Sign up or log in

Post as a guest

Related