Python while loop is not functioning correctly (beginner)

Question

I'm still quite new to Python and am confused as to what's happening with a program I'm working on. The code is below. The problem is the code is never running any of the if/elif/else lines. It just keeps cycling the menu and inputs. I'm using 3.2.

# Program to Add, Subtract, Multiply, and Divide

def printmenu():
    print("Calculator v0.01")
    print("[A]dd Two Numbers")
    print("[S]ubtract Two Numbers")
    print("[M]ultiply Two Numbers")
    print("[D]ivide Two Numbers")
    print("[Q]uit the Program")

choice = "x"

while choice.lower != "q":
    printmenu()
    choice = input("What would you like to do? ")
    firstnum = input("What is the first number? ")
    secnum = input("What is the second number? ")
    if choice.lower == "a":
        print("The answer is ",  (firstnum + secnum))
    elif choice.lower == "s":
        print("The answer is ",  (firstnum - secnum))
    elif choice.lower == "m":
        print("The answer is ",  (firstnum * secnum))
    elif choice.lower == "d":
        print("The answer is ",  (firstnum / secnum))
    else:
        print("Choice not recognized.  Try again!")

P.S. - This is my first post on here, so if I'm not doing something properly then please let me know.

Thanks!

JT

Your post is fine - your question title is indicative of the content of the post/what you want answered, you supply the code that is not working, you say what is not working and what you expect to happen instead. — Patashu
– Patashu, Commented Apr 20, 2013 at 11:24

Patashu · Accepted Answer · 2013-04-20 11:20:52Z

3

>>> "a".lower
<built-in method lower of str object at 0x0000000001EBBBC0>
>>> "a".lower()
'a'
>>> "a".lower == "a"
False
>>> "a".lower() == "a"
True
>>>

I think you meant lower(), not lower ;)

answered Apr 20, 2013 at 11:20

Patashu

21.8k4 gold badges49 silver badges53 bronze badges

Sign up to request clarification or add additional context in comments.

1 Comment

JT Bowlin Over a year ago

Yes, that was it! Of course now it's not acting correctly because I didn't convert the nums to float/int so 5 +2 = 52, but that's easy enough to fix by putting float(input()). Thanks for your help.

Aswin Murugesh · Accepted Answer · 2013-04-20 11:24:43Z

0

all inbuilt functions in python should be called using (). So use

if choice.lower()!="q":

Only then the function is called. Else the value is always returned False, since no function is executed

answered Apr 20, 2013 at 11:24

Aswin Murugesh

11.1k11 gold badges46 silver badges73 bronze badges

Comments

Jeremy D · Accepted Answer · 2013-04-20 11:25:51Z

0

Replace lower by lower()
Use float(fisrtnum) + float(secnum) as otherwise it will just concatenate the char and gives 23 for '2'+'3'

answered Apr 20, 2013 at 11:25

Jeremy D

4,8551 gold badge34 silver badges39 bronze badges

Collectives™ on Stack Overflow

Python while loop is not functioning correctly (beginner)

3 Answers 3

1 Comment

Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

3 Answers 3

1 Comment

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related