Simple javascript function issue

Question

I am trying to pass an argument to a onclick function using javascript

I had before

 title = createElement('span', {className: 'title', innerHTML: this.Title,
            ID: this.ID, Title: this.Title, onclick: TitleOnClick});

I am passing parameter 'test'..

    title = createElement('span', {className: 'title', innerHTML: this.Title,
            ID: this.ID, Title: this.Title, onclick: TitleOnClick(test)});


function TitleOnClick(test){
       alert(test);
}

Don't seem to work. Am I doing it wrong? Thanks a lot!

Troy Alford · Accepted Answer · 2012-09-20 17:19:48Z

2

When you call it that way, what you are doing is setting the value of onclick equal to the RETURN value of TitleOnClick(test). What you probably want to do, instead, is something like:

onclick: TitleOnClick (note no ()'s) - and then within that method, derive the value of test based on context.

answered Sep 20, 2012 at 17:19

Troy Alford

27.3k11 gold badges67 silver badges85 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

Pointy · Accepted Answer · 2012-09-20 17:21:34Z

0

You can wrap the call to "TitleOnClick" in another function:

title = createElement('span', {className: 'title', innerHTML: this.Title,
        ID: this.ID, Title: this.Title, onclick: function() { TitleOnClick(test); }});

(Assumes the variable "test" is declared somewhere, as did your example.)

answered Sep 20, 2012 at 17:21

Pointy

415k62 gold badges600 silver badges631 bronze badges

Collectives™ on Stack Overflow

Simple javascript function issue

2 Answers 2

Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related