Method that returns string containing multiple variables

Question

Here is a constructor I wrote that holds address information, but I'm having trouble with the final part, where I have to return a string that holds name, address, city, state zipcode. What would be the correct way to write it?

public class Address {

private String name;
private String address;
private String state;
private String city;
private String zipcode;

public Address(String name, String address, String state, String city, String zipcode){

    this.name = name;
    this.address = address;
    this.state = state;
    this.city = city;
    this.zipcode = zipcode;


}

public Address(){

    name = "occupant";
    address = " ";
    state = " ";
    city = " ";
    zipcode = " ";


}

public void setAddress(String Address){

    this.address = Address;

}

public void setstate(String state){

    this.state= state;


}

public void setcity(String city){

    this.city = city;
}

public void setzipcode(String code){

   this.zipcode = code; 

}

public String getaddress(){  // Return string that contains name and address and city and zipcode

    return getaddress() + " " + return state + " " + return city + " " + return code;



}

}

Do you need it in one whole string? Or could it be an array of strings? Also why are you calling getaddress() inside getaddress()???? — dann.dev
– dann.dev, Commented Apr 4, 2012 at 21:51

Bozho · Accepted Answer · 2012-04-04 21:50:10Z

3

 return address + " " + state + " " + city + " " + code;

A few notes:

only one return, followed by the object to return, which is a result of string concatenation
call your concatenating method getFullAddress() to distinguish it from the getter.
use lower-case variable names
getters and setters should get camel-case: setCity(), getState()

answered Apr 4, 2012 at 21:50

Bozho

599k147 gold badges1.1k silver badges1.2k bronze badges

Sign up to request clarification or add additional context in comments.

2 Comments

Kevin Over a year ago

I would also like to point out that you can override your address object's toString

Bozho Over a year ago

yes, but since .toString() should be used mainly for debugging, if he needs this for other purposes, he'd better make a new method

TechTrip · Accepted Answer · 2012-04-04 22:04:33Z

1

I would rename the variable address to street for clarity. No matter though, rather than overridding toString() I would add getters on each of the fields and add a static utility class to print the address with the following method

static String formatAddress(Address address){
    final String formatter = "Address\n%s\n%s\n%s, %s  %s";
    return String.format(formatter, address.getName(),address.getAddress(),address.getCity(), address.getState(), address.getZipcode());
}

answered Apr 4, 2012 at 22:04

TechTrip

4,5872 gold badges24 silver badges16 bronze badges

1 Comment

TechTrip Over a year ago

Obviously this is a simple formatter but it should get you on the path.

dann.dev · Accepted Answer · 2012-04-04 21:51:45Z

0

I think your problem is probably that you are calling getaddress() inside of getaddress() rather than using address

EDIT: and as Bozho pointed out, only one return per statement in a method.

answered Apr 4, 2012 at 21:51

dann.dev

2,5033 gold badges21 silver badges32 bronze badges

Collectives™ on Stack Overflow

Method that returns string containing multiple variables

3 Answers 3

2 Comments

1 Comment

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

3 Answers 3

2 Comments

1 Comment

Comments

Your Answer

Sign up or log in

Post as a guest

Related