Optimization of code removing extra if and else block

Question

I need to remove the extra if and else loop as per the req and need to make it short for reading of the code should be easy. can anyone suggest some better for below:

if (data[0].FA_N__c) {
            if (test === false) {
                this.cl = acL;
            }
            else if (test === true) {
                this.cl = acWo;
            }
        }
        else {
            if (test === false) {
                this.cl = nAc;
            }
            else if (test === true) {
                this.cl = nAcWo;
            }
        }
    }

If we're talking about readability, I don't find those variable names very readable. — nbrown
– nbrown, Commented Jul 8, 2020 at 14:55

sanket kumar · Accepted Answer · 2020-07-08 06:35:19Z

1

make use of Conditional (ternary) operator in JavaScript to make your code short:-

        if (data[0].FA_N__c) {
            this.cl = test ? acWo : acL;
        }else {
            this.cl = test ? nAcWo : nAc;
        }

answered Jul 8, 2020 at 6:35

sanket kumar

15.8k2 gold badges32 silver badges61 bronze badges

Add a comment |

Daniel Koch · Accepted Answer · 2020-07-08 06:33:24Z

0

A little bit more context of where the code is structured in will be fine :)

When you have the possibility to make a return, you can do something like this:

if (data[0].FA_N__c) {
  if (test === false) {
    this.cl = acL;
    return;
  }

  this.cl = acWo;
  return;
}

if (test === false) {
  this.cl = nAc;
  return;
}

this.cl = nAcWo;

When your are inside a loop, you can replace the return with a continue.

answered Jul 8, 2020 at 6:33

Daniel Koch

1431 silver badge8 bronze badges

Add a comment |

Stack Exchange Network

Optimization of code removing extra if and else block

2 Answers 2

You must log in to answer this question.

Hot Network Questions

Optimization of code removing extra if and else block

2 Answers 2

You must log in to answer this question.

Related

Hot Network Questions