feat(ts-codeLens): show "implementations" CodeLens for overridden methods #263749 #264546

ritesh006 · 2025-09-02T12:56:49Z

Summary
This PR adds support for showing "implementations" CodeLens on TypeScript methods that are overridden in derived classes.

Changes
Extended TypeScriptImplementationsCodeLensProvider to surface implementations for:
Class methods (not just interfaces or abstract methods)
Overridden methods in derived classes
Updated extractSymbol logic to correctly identify these symbols
Added smoke test: implementationsCodeLens.test.ts to validate behavior
Why
Resolves #198387.

Developers can now see "1 implementation" / "n implementations" CodeLens above methods that are overridden, and navigate directly to their derived class implementations.
This aligns CodeLens behavior with the “Find All Implementations” command.

Verification
Open an abstract/base class with a method that is overridden in derived classes.
Confirm that the "implementations" CodeLens appears above the method.
Clicking it navigates to the derived class overrides.
Testing
Local build & compile successful
Hygiene checks passed
Smoke test added & executed
Integration tests run successfully (scripts/test-integration.bat)
Notes
This improvement makes CodeLens more consistent and increases productivity when working with object-oriented TypeScript codebases.

Fixes #198387

ritesh006 · 2025-09-02T12:57:24Z

Hi team 👋
This PR implements “implementations” CodeLens for overridden methods (#198387).

Local tests ✅

Integration tests ✅

Hygiene checks ✅
Looking forward to your review. Please approve workflows when possible so CI can run.
Thanks!

ritesh006 · 2025-09-04T18:36:54Z

could someone review this please

mjbvz · 2025-09-04T20:37:45Z

@ritesh006 We are currently preparing the August release. This PR came in too late to make it in but I've scheduled it for September. Will review it next week when I have a chance

mjbvz

Looks like the code change may have been lost? I only see the new test file and a single new line change

ritesh006 · 2025-09-06T06:35:24Z

Thanks for the catch, @mjbvz a merge from main had dropped the provider changes. I’ve restored them and force pushed. The PR now includes the updates in implementationsCodeLens.ts

jabari-max

@mjbvz

mjbvz · 2025-09-08T18:43:40Z

I'm still only seeing 1 file changed. Can you try again to make sure the other files are included

Also no need to explicitly keep copying me

ritesh006 · 2025-09-09T13:12:28Z

Ready for review

mjbvz · 2025-09-09T16:47:07Z

...nsions/typescript-language-features/src/languageFeatures/codeLens/implementationsCodeLens.ts

 	}

 	private getCommand(locations: vscode.Location[], codeLens: ReferencesCodeLens): vscode.Command | undefined {
+		if (!locations.length) {


We still want to show 0 implementations in this case. If you want to avoid showing the code lens for methods with no overrides, that should be handled differently

extensions/typescript-language-features/src/test/smoke/implementationsCodeLens.test.ts

...nsions/typescript-language-features/src/languageFeatures/codeLens/implementationsCodeLens.ts

ritesh006 · 2025-09-09T17:28:58Z

Ready for reviw

...nsions/typescript-language-features/src/languageFeatures/codeLens/implementationsCodeLens.ts

ritesh006 · 2025-09-10T12:59:11Z

Ready for Review.

mjbvz · 2025-09-10T18:00:38Z

...nsions/typescript-language-features/src/languageFeatures/codeLens/implementationsCodeLens.ts

+	}
+
+	// Class methods (behind new setting; default off)
+	if (


What about the other types that were previously in the switch?

ritesh006 · 2025-09-17T09:49:38Z

Hi @mjbvz ready for review please have a look

mjbvz · 2025-09-17T20:13:45Z

...nsions/typescript-language-features/src/languageFeatures/codeLens/implementationsCodeLens.ts

-				}
-				break;
+		if (
+			(item.kind === PConst.Kind.method


Looks like class got dropped from this list

mjbvz · 2025-09-17T20:14:59Z

...nsions/typescript-language-features/src/languageFeatures/codeLens/implementationsCodeLens.ts

+			parent?.kind === PConst.Kind.class &&
+			cfg.get<boolean>('implementationsCodeLens.showOnClassMethods', false)
+		) {
+			return getSymbolRange(document, item);


We should skip showing these on private methods as these cannot be overridden

extensions/typescript-language-features/package.json

ritesh006 · 2025-09-18T02:49:23Z

HI @mjbvz due to family loss I went to my hometown. as soon as I reach to my place I would like to start work again.

ritesh006 · 2025-09-26T07:17:01Z

Hi @mjbvz Ready for review

mjbvz · 2025-09-26T20:34:36Z

Thanks, looks like there are still a few unresolved comments: https://github.com/microsoft/vscode/pull/264546/files#diff-2c8c54699e981dcd79e99a1b8cbc2690c7b751ac4b160fe7fd3f271835b5b878

Can you please take a look a those

Since it's a little late for the September release, we'll also target the October release for getting this merged

ritesh006 · 2025-10-01T11:39:54Z

Hi @mjbvz Ready for review

ritesh006 · 2025-10-01T11:40:40Z

Hi @mjbvz Ready for review

please let me know if anything I missed and so sorry for late reply

...nsions/typescript-language-features/src/languageFeatures/codeLens/implementationsCodeLens.ts

extensions/typescript-language-features/src/test/smoke/implementationsCodeLens.test.ts

ritesh006 · 2025-10-11T05:20:02Z

Ready For Review @mjbvz

mjbvz · 2025-10-15T07:41:42Z

Added some extra tests to have more confidence in this change. Also renamed it to showOnAllClassMethods

bpasero · 2025-10-15T07:54:12Z

@mjbvz red CI

vs-code-engineering bot assigned mjbvz Sep 2, 2025

mjbvz added this to the September 2025 milestone Sep 2, 2025

mjbvz reviewed Sep 5, 2025

View reviewed changes

ritesh006 force-pushed the test/implementations-codelens branch from 53cc94d to 21cbca8 Compare September 6, 2025 05:46

jabari-max reviewed Sep 6, 2025

View reviewed changes

ritesh006 force-pushed the test/implementations-codelens branch 6 times, most recently from a2dd3f6 to 85cc11c Compare September 9, 2025 13:11

mjbvz reviewed Sep 9, 2025

View reviewed changes

ritesh006 force-pushed the test/implementations-codelens branch from 5437400 to 2a6a06a Compare September 9, 2025 17:26

mjbvz reviewed Sep 9, 2025

View reviewed changes

...nsions/typescript-language-features/src/languageFeatures/codeLens/implementationsCodeLens.ts Outdated Show resolved Hide resolved

ritesh006 force-pushed the test/implementations-codelens branch 2 times, most recently from f1f2365 to f73e56b Compare September 10, 2025 12:56

mjbvz reviewed Sep 10, 2025

View reviewed changes

ritesh006 force-pushed the test/implementations-codelens branch 5 times, most recently from 3407cb2 to c0e26f7 Compare September 11, 2025 03:48

mjbvz reviewed Sep 17, 2025

View reviewed changes

ritesh006 force-pushed the test/implementations-codelens branch 2 times, most recently from 1202b7b to c0e26f7 Compare September 26, 2025 07:15

mjbvz modified the milestones: September 2025, October 2025 Sep 26, 2025

ritesh006 force-pushed the test/implementations-codelens branch from c0e26f7 to 4b77716 Compare October 1, 2025 11:38

mjbvz requested changes Oct 6, 2025

View reviewed changes

ts-codelens: implementations for overrides + test

cd5348a

ritesh006 force-pushed the test/implementations-codelens branch from 67b5546 to cd5348a Compare October 11, 2025 05:19

ritesh006 and others added 2 commits October 11, 2025 10:50

Merge branch 'main' into test/implementations-codelens

1d291cd

Update tests and small tweaks

c099047

mjbvz enabled auto-merge October 15, 2025 07:40

Doc fixes

c3bcc16

mjbvz previously approved these changes Oct 15, 2025

View reviewed changes

alexr00 previously approved these changes Oct 15, 2025

View reviewed changes

Fix string name

40fd1d8

mjbvz dismissed stale reviews from alexr00 and themself via 40fd1d8 October 15, 2025 17:16

dbaeumer approved these changes Oct 29, 2025

View reviewed changes

mjbvz approved these changes Nov 3, 2025

View reviewed changes

mjbvz merged commit 078d0d5 into microsoft:main Nov 3, 2025
17 checks passed

feat(ts-codeLens): show "implementations" CodeLens for overridden methods #263749 #264546

feat(ts-codeLens): show "implementations" CodeLens for overridden methods #263749 #264546

Conversation

ritesh006 commented Sep 2, 2025

Uh oh!

ritesh006 commented Sep 2, 2025

Uh oh!

ritesh006 commented Sep 4, 2025

Uh oh!

mjbvz commented Sep 4, 2025

Uh oh!

mjbvz left a comment

Choose a reason for hiding this comment

Uh oh!

ritesh006 commented Sep 6, 2025

Uh oh!

jabari-max left a comment

Choose a reason for hiding this comment

Uh oh!

mjbvz commented Sep 8, 2025

Uh oh!

ritesh006 commented Sep 9, 2025

Uh oh!

mjbvz Sep 9, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

ritesh006 commented Sep 9, 2025

Uh oh!

Uh oh!

ritesh006 commented Sep 10, 2025

Uh oh!

mjbvz Sep 10, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

ritesh006 commented Sep 17, 2025

Uh oh!

mjbvz Sep 17, 2025

Choose a reason for hiding this comment

Uh oh!

mjbvz Sep 17, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

ritesh006 commented Sep 18, 2025

Uh oh!

ritesh006 commented Sep 26, 2025

Uh oh!

mjbvz commented Sep 26, 2025

Uh oh!

ritesh006 commented Oct 1, 2025

Uh oh!

ritesh006 commented Oct 1, 2025

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

ritesh006 commented Oct 11, 2025

Uh oh!

mjbvz commented Oct 15, 2025

Uh oh!

bpasero commented Oct 15, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

mjbvz Sep 10, 2025 •

edited

Loading