Replace ReadFile/WriteFile usages with stdio #116203
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
huoyaoyuan
commented
Jun 2, 2025
huoyaoyuan
commented
Jun 3, 2025
jkotas
reviewed
Jun 4, 2025
jkotas
reviewed
Jun 4, 2025
jkotas
reviewed
Jun 4, 2025
Open
3 tasks
This was referenced Nov 8, 2025
AaronRobinsonMSFT
approved these changes
Nov 13, 2025
Member
AaronRobinsonMSFT
left a comment
There was a problem hiding this comment.
As soon as the CI is green, I'm good.
Thank you!
jkotas
reviewed
Nov 13, 2025
Member
|
/azp run runtime-coreclr ilasm |
|
Azure Pipelines successfully started running 1 pipeline(s). |
3 tasks
d31030c to
6553e8c
Compare
Member
|
@huoyaoyuan I think the ILAsm outer loop has related failures. |
Member
Author
|
I don't think the failure looks related. All the failures are on ARM64, about Sve2.ShiftArithmeticSaturate. It looks like #121659. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replaces the majority of ReadFile/WriteFile instances with stdio, and fstream for some superpmi cases.
Remaining instances are StgIO and superpmi/fileio, which uses the same file handles for memory map.
This PR aims to remove as much ReadFile/WriteFile instances with as little change. Opening earlier for some questions.