Skip to content

HTTP/3: QPACK decoder performance #38826

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Dec 7, 2021
Merged

HTTP/3: QPACK decoder performance #38826

merged 4 commits into from
Dec 7, 2021

Conversation

@JamesNK
Copy link
Member

@JamesNK JamesNK commented Dec 5, 2021

Before:

|                                           Method |          Mean |        Error |       StdDev |         Op/s | Gen 0 | Gen 1 | Gen 2 | Allocated |
|------------------------------------------------- |--------------:|-------------:|-------------:|-------------:|------:|------:|------:|----------:|
|          DecodeHeaderFieldLine_LargeLiteralValue |  73,798.03 ns | 1,406.262 ns | 1,504.685 ns |     13,550.5 |     - |     - |     - |         - |
| DecodeHeaderFieldLine_LargeLiteralValue_Multiple | 409,622.33 ns | 6,067.124 ns | 5,378.347 ns |      2,441.3 |     - |     - |     - |         - |
|            DecodeHeaderFieldLine_Static_Multiple |      61.78 ns |     0.743 ns |     0.620 ns | 16,187,009.9 |     - |     - |     - |         - |

After:

|                                           Method |      Mean |    Error |   StdDev |         Op/s | Gen 0 | Gen 1 | Gen 2 | Allocated |
|------------------------------------------------- |----------:|---------:|---------:|-------------:|------:|------:|------:|----------:|
|          DecodeHeaderFieldLine_LargeLiteralValue |  82.09 ns | 1.526 ns | 1.191 ns | 12,182,061.0 |     - |     - |     - |         - |
| DecodeHeaderFieldLine_LargeLiteralValue_Multiple | 365.05 ns | 5.234 ns | 4.640 ns |  2,739,381.0 |     - |     - |     - |         - |
|            DecodeHeaderFieldLine_Static_Multiple |  63.02 ns | 1.269 ns | 1.187 ns | 15,867,472.9 |     - |     - |     - |         - |

@JamesNK JamesNK requested a review from a team December 5, 2021 08:34
halter73
halter73 reviewed Dec 6, 2021
View reviewed changes
halter73
halter73 reviewed Dec 6, 2021
View reviewed changes
halter73
halter73 reviewed Dec 6, 2021
View reviewed changes
halter73
halter73 approved these changes Dec 6, 2021
View reviewed changes
Copy link
Member

@halter73 halter73 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

900x improvement for DecodeHeaderFieldLine_LargeLiteralValue 🎉

@Tratcher
Copy link
Member

Tratcher commented Dec 6, 2021

900x improvement for DecodeHeaderFieldLine_LargeLiteralValue 🎉

What could possibly go wrong😁?

@JamesNK JamesNK merged commit 04789d5 into main Dec 7, 2021
@JamesNK JamesNK deleted the jamesnk/qpack-decoder-perf branch December 7, 2021 01:47
@ghost ghost added this to the 7.0-preview1 milestone Dec 7, 2021
@JamesNK JamesNK mentioned this pull request Dec 7, 2021
Merged
@davidfowl davidfowl added the Perf label Aug 26, 2022
@amcasey amcasey added area-networking Includes servers, yarp, json patch, bedrock, websockets, http client factory, and http abstractions and removed area-runtime labels Aug 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@halter73 halter73 halter73 approved these changes

Assignees

No one assigned

Labels

area-networking Includes servers, yarp, json patch, bedrock, websockets, http client factory, and http abstractions Perf

Projects

None yet

Milestone

7.0-preview1

Development

Successfully merging this pull request may close these issues.

6 participants

@JamesNK @Tratcher @halter73 @davidfowl @amcasey