Extend ReadOnlyModelViewSet with prefetch mixins #439
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change creates a ReadOnlyModelViewSet with the required prefetch mixins.
Contributor
Author
|
I'll tick off the rest of the checklist in time. |
Codecov Report
@@ Coverage Diff @@
## master #439 +/- ##
==========================================
+ Coverage 91.92% 91.92% +<.01%
==========================================
Files 57 57
Lines 2984 2986 +2
==========================================
+ Hits 2743 2745 +2
Misses 241 241
Continue to review full report at Codecov.
|
Member
|
I thought update adding this in the past as well but never really got around. Hope you will get around the other points in the checklist and then I am happy to merge it. |
sliverc
approved these changes
May 22, 2018
Member
sliverc
left a comment
There was a problem hiding this comment.
Awesome! Thanks for your contribution.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change creates a ReadOnlyModelViewSet with the required prefetch mixins.
Description of the Change
Checklist
CHANGELOG.mdAUTHORS