With optimized js enabled, my javascript code not working

Question

I have a drop down list. On the change event of the drop down list I have written some javascript code. When I select an option from the drop down list a site opens in the new window.

So for this I wrote some javascript code on the change event of the drop down list.

But the problem is that when I enable the optimize js files then my drop down change event does not work and when I disable the optimize js files then the change event of the drop down works.

So what should I do for this to work in both condition?

UPDATED:

Drupal.behaviors.change = function (context) {


    $(".test").change(function(){
        var page = $(".test").val();
        window.open(''+page+'', '_blank');
    }) ;

};

Can you look into the error console Ctrl + Shift + J and post the errors ? If its an error like $ is not defined then its because Jquery Library is loaded after your scripts are loaded as said by ninjascorner — GoodSp33d
– GoodSp33d, Commented Jun 19, 2012 at 8:02

ninjascorner · Accepted Answer · 2012-06-19 06:48:38Z

1

The reason maybe is your custom script loads first before the Jquery script.

Try this:

(function($) {
  $(function() { 
    //your script here
  });
})(jQuery);

or

Drupal.behaviors.somethingHere = function (context) {
  //your script here
}

answered Jun 19, 2012 at 6:48

ninjascorner

1,8413 gold badges23 silver badges33 bronze badges

1

It may also be cache problem. Try to flush the cache and see what happens?

Mika A.
– Mika A.

2012-06-19 06:59:09 +00:00
Commented Jun 19, 2012 at 6:59
I tried both of your methods but it also did not work. See my question again, I have updated it with my js code.

Ahmad
– Ahmad

2012-06-19 10:50:11 +00:00
Commented Jun 19, 2012 at 10:50
How/where did you add the script?

ninjascorner
– ninjascorner

2012-06-20 09:09:45 +00:00
Commented Jun 20, 2012 at 9:09
direct in the module file using drupal_add_js("js_code", "inline", "footer", FALSE, FALSE);

Ahmad
– Ahmad

2012-06-20 09:30:25 +00:00
Commented Jun 20, 2012 at 9:30

Add a comment |

mpdonadio · Accepted Answer · 2012-06-19 14:41:25Z

0

This is a shot in the dark, but when you concatenate Javascript files, the problem could actually be from another file and not the one that isn't working. I would try using

;Drupal.behaviors.change = function (context) {
    $(".test").change(function(){
        var page = $(".test").val();
        window.open(''+page+'', '_blank');
    }) ;
};

Note the semicolon at the beginning. If the previous file is missing a semi-colon, it may work on its own, but result in a syntax error when you concatenate. Out of habit, everything I declare at the top-level gets these.

answered Jun 19, 2012 at 14:41

mpdonadio♦

38.1k8 gold badges90 silver badges143 bronze badges

did not work :(

Ahmad
– Ahmad

2012-06-20 04:57:11 +00:00
Commented Jun 20, 2012 at 4:57

Add a comment |

Stack Exchange Network

With optimized js enabled, my javascript code not working

2 Answers 2

Your Answer

Hot Network Questions

With optimized js enabled, my javascript code not working

2 Answers 2

Your Answer

Sign up or log in

Post as a guest

Related

Hot Network Questions